INNOCENT-BOY commented on code in PR #12138:
URL: https://github.com/apache/pinot/pull/12138#discussion_r1423503228
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##
@@ -120,6 +120,9 @@ record = transformer.transf
jackluo923 commented on issue #9154:
URL: https://github.com/apache/pinot/issues/9154#issuecomment-1851229675
@rohityadav1993 @kkrugler @TT1103 Could you test out the latest change on
the master branch? I haven't had time to update the docs, but will do it soon.
For now, just change the fo
Jackie-Jiang commented on code in PR #12115:
URL: https://github.com/apache/pinot/pull/12115#discussion_r1423332268
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/TableConfigPartitioner.java:
##
@@ -41,6 +43,16 @@ public TableConfigPartitioner(S
Jackie-Jiang commented on code in PR #11985:
URL: https://github.com/apache/pinot/pull/11985#discussion_r1423319027
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##
@@ -47,100 +47,69 @@ public class CommonsConfigurationUtils {
private Com
Jackie-Jiang commented on code in PR #12138:
URL: https://github.com/apache/pinot/pull/12138#discussion_r1423316973
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##
@@ -120,6 +120,9 @@ record = transformer.transf
Jackie-Jiang merged PR #12137:
URL: https://github.com/apache/pinot/pull/12137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d38e15d1fa fixes #12136 (#12137)
d38e15d1fa is de
Jackie-Jiang closed issue #12136: fix malformed calls to `String.format`
URL: https://github.com/apache/pinot/issues/12136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
swaminathanmanish commented on code in PR #12115:
URL: https://github.com/apache/pinot/pull/12115#discussion_r1423311235
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/TableConfigPartitioner.java:
##
@@ -41,6 +43,16 @@ public TableConfigPartitio
Jackie-Jiang commented on PR #12048:
URL: https://github.com/apache/pinot/pull/12048#issuecomment-1851167202
Checking the code, and I feel the problem is raised from the
`ExplainPlanDataTableReducer.extractUniqueExplainPlansAcrossServers()` where we
try to extract the unique explain plans.
Jackie-Jiang commented on code in PR #11953:
URL: https://github.com/apache/pinot/pull/11953#discussion_r1423299335
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceReplicaGroupPartitionSelector.java:
##
@@ -73,16 +76,65 @@ pub
abhioncbr commented on PR #11985:
URL: https://github.com/apache/pinot/pull/11985#issuecomment-1851143998
Please review once more @Jackie-Jiang. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 92e26a5847 Introduce UpsertContext to simplify th
Jackie-Jiang merged PR #12120:
URL: https://github.com/apache/pinot/pull/12120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #12111:
URL: https://github.com/apache/pinot/issues/12111#issuecomment-1851057424
This is a great optimization!
Ideally we should provide a mapping from query `AggregationFunctionType` to
aggregator `AggregationFunctionType`, which is already happening impl
Jackie-Jiang commented on code in PR #12115:
URL: https://github.com/apache/pinot/pull/12115#discussion_r1423208731
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/TableConfigPartitioner.java:
##
@@ -41,6 +43,16 @@ public TableConfigPartitioner(S
swaminathanmanish commented on code in PR #12115:
URL: https://github.com/apache/pinot/pull/12115#discussion_r1423195561
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/TableConfigPartitioner.java:
##
@@ -41,6 +43,16 @@ public TableConfigPartitio
Jackie-Jiang commented on code in PR #12135:
URL: https://github.com/apache/pinot/pull/12135#discussion_r1423137832
##
pinot-core/src/main/java/org/apache/pinot/core/util/OsCheck.java:
##
@@ -46,9 +48,11 @@ public enum OSType {
Windows, MacOS, Linux, Other
}
+ private
Jackie-Jiang commented on code in PR #12134:
URL: https://github.com/apache/pinot/pull/12134#discussion_r1423133442
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##
@@ -154,7 +154,7 @@ protected synchronized void
deleteSeg
Jackie-Jiang commented on code in PR #12130:
URL: https://github.com/apache/pinot/pull/12130#discussion_r1423121540
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/RangeIndexCreator.java:
##
@@ -321,6 +322,7 @@ public void seal()
xiangfu0 merged PR #12140:
URL: https://github.com/apache/pinot/pull/12140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f4b5de6b8a [hotfix] remove non-exist vector tran
walterddr commented on issue #12136:
URL: https://github.com/apache/pinot/issues/12136#issuecomment-1850772221
echo back to
https://github.com/apache/pinot/issues/12132#issuecomment-1850771286. we should
enforce the rule in checkstyle
--
This is an automated message from the Apache Git
walterddr commented on issue #12132:
URL: https://github.com/apache/pinot/issues/12132#issuecomment-1850771286
wondering if this should be captured by Checkstyle rules
for example `String.format("{}, {}", arg1, arg2, arg3)` will be captured by
checkstyle rule that the arg count mismatch.
walterddr merged PR #12128:
URL: https://github.com/apache/pinot/pull/12128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
walterddr closed issue #12127: Loggers initialized with foreign classes
URL: https://github.com/apache/pinot/issues/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d68a5a8dac PR to address Issue #12127 - Refactor f
Jackie-Jiang closed pull request #12139: Bump net.java.dev.jna:jna from 5.5.0
to 5.14.0
URL: https://github.com/apache/pinot/pull/12139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] commented on PR #12139:
URL: https://github.com/apache/pinot/pull/12139#issuecomment-1850521295
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/net.java.dev.jna-jna-5.14.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 9b96541bd0 Bump net.java.dev.jna:jna from 5.5.0 to 5.14.0
The revisions tha
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.github.luben-zstd-jni-1.5.5-11
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 6ff8b05d5e Bump com.github.luben:zstd-jni from 1.5.5-6 to 1.5.5-11
The r
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from ed8a251f07 Bump com.google.guava:guava from 32.0.1-jre to 32.1.3-jre
(#12124)
add a4e5fa3326 Bump com.github.lube
Jackie-Jiang merged PR #12125:
URL: https://github.com/apache/pinot/pull/12125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.google.guava-guava-32.1.3-jre
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4ccb469b5e Bump com.google.guava:guava from 32.0.1-jre to 32.1.3-jre
The
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/pulsar.version-3.1.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4852a28916 Bump pulsar.version from 2.11.0 to 3.1.1
The revisions that were on this
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ed8a251f07 Bump com.google.guava:guava from 32.0.
Jackie-Jiang merged PR #12124:
URL: https://github.com/apache/pinot/pull/12124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
dependabot[bot] commented on PR #12123:
URL: https://github.com/apache/pinot/pull/12123#issuecomment-1850505111
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
Jackie-Jiang closed pull request #12123: Bump pulsar.version from 2.11.0 to
3.1.1
URL: https://github.com/apache/pinot/pull/12123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1422823809
##
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
Stri
walterddr opened a new pull request, #12140:
URL: https://github.com/apache/pinot/pull/12140
vector_similarity is not a transform function type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
walterddr commented on code in PR #11977:
URL: https://github.com/apache/pinot/pull/11977#discussion_r1422621407
##
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##
@@ -264,6 +264,9 @@ public enum TransformFunctionType {
OperandTy
davecromberge commented on issue #12111:
URL: https://github.com/apache/pinot/issues/12111#issuecomment-1850111531
Instead of de-duplication, I have decided to extend the configuration so
that the user can associate one or more "virtual" aggregation functions with
each aggregation spec. Wh
codecov-commenter commented on PR #12139:
URL: https://github.com/apache/pinot/pull/12139#issuecomment-1849965116
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12139?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
dependabot[bot] commented on PR #10537:
URL: https://github.com/apache/pinot/pull/10537#issuecomment-1849904809
Superseded by #12139.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/net.java.dev.jna-jna-5.14.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 9b96541bd0 Bump net.java.dev.jna:jna from 5.5.0 to 5.14.0
No new revisions
dependabot[bot] opened a new pull request, #12139:
URL: https://github.com/apache/pinot/pull/12139
Bumps [net.java.dev.jna:jna](https://github.com/java-native-access/jna) from
5.5.0 to 5.14.0.
Changelog
Sourced from https://github.com/java-native-access/jna/blob/master/CHANGES.md";
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/net.java.dev.jna-jna-5.13.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was eeb13fec87 Bump jna from 5.6.0 to 5.13.0
The revisions that were on this br
dependabot[bot] closed pull request #10537: Bump jna from 5.6.0 to 5.13.0
URL: https://github.com/apache/pinot/pull/10537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
49 matches
Mail list logo
