walterddr commented on code in PR #11977: URL: https://github.com/apache/pinot/pull/11977#discussion_r1422621407
########## pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java: ########## @@ -264,6 +264,9 @@ public enum TransformFunctionType { OperandTypes.family(ImmutableList.of(SqlTypeFamily.ARRAY)), "vector_dims"), VECTOR_NORM("vectorNorm", ReturnTypes.explicit(SqlTypeName.DOUBLE), OperandTypes.family(ImmutableList.of(SqlTypeFamily.ARRAY)), "vector_norm"), + VECTOR_SIMILARITY("vectorSimilarity", ReturnTypes.explicit(SqlTypeName.DOUBLE), + OperandTypes.family(ImmutableList.of(SqlTypeFamily.ARRAY, SqlTypeFamily.ARRAY, SqlTypeFamily.CHARACTER), + ordinal -> ordinal > 1 && ordinal < 4), "vector_similarity"), Review Comment: we dont have transform function impl. only filter op. will remove it if no objection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org