Jackie-Jiang commented on code in PR #12138:
URL: https://github.com/apache/pinot/pull/12138#discussion_r1423316973
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##########
@@ -120,6 +120,9 @@ record = transformer.transform(record);
if (record == null) {
return null;
}
+ if (Boolean.TRUE.equals(record.getValue(GenericRow.SKIP_RECORD_KEY))) {
Review Comment:
We should move this to line 118 (before the for loop). We may use
`IngestionUtils.shouldIngestRow(record)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
