Re: [PR] fix multiple instances where the number of placeholders did not match the number of arguments to logging methods [pinot]

[via GitHub]

Jackie-Jiang commented on code in PR #12134:
URL: https://github.com/apache/pinot/pull/12134#discussion_r1423133442


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -154,7 +154,7 @@ protected synchronized void 
deleteSegmentFromPropertyStoreAndLocal(String tableN
         }
       }
     } catch (Exception e) {
-      LOGGER.warn("Caught exception while checking helix states for table {} " 
+ tableName, e);
+      LOGGER.warn(String.format("Caught exception while checking helix states 
for table [%s]", tableName), e);

Review Comment:
   ```suggestion
         LOGGER.warn("Caught exception while checking helix states for table: 
{}", tableName, e);
   ```



##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -379,7 +379,7 @@ private boolean endCriteriaReached() {
         }
         return false;
       default:
-        _segmentLogger.error("Illegal state {}" + _state.toString());
+        _segmentLogger.error("Illegal state [{}]", _state.toString());

Review Comment:
   ```suggestion
           _segmentLogger.error("Illegal state: {}", _state);
   ```



##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java:
##########
@@ -102,7 +102,7 @@ public void shutDown() {
       Future future = entry.getValue();
       boolean cancelled = future.cancel(true);
       if (!cancelled) {
-        LOGGER.warn("Task could not be cancelled for {}" + entry.getKey());
+        LOGGER.warn("Task could not be cancelled for [{}]", entry.getKey());

Review Comment:
   ```suggestion
           LOGGER.warn("Task could not be cancelled for {}", entry.getKey());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org