INNOCENT-BOY commented on code in PR #12138:
URL: https://github.com/apache/pinot/pull/12138#discussion_r1423503228
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##########
@@ -120,6 +120,9 @@ record = transformer.transform(record);
if (record == null) {
return null;
}
+ if (Boolean.TRUE.equals(record.getValue(GenericRow.SKIP_RECORD_KEY))) {
Review Comment:
Hi @Jackie-Jiang . I don't find any other operations which could mark record
as SKIP_RECORD instead of `FilterTransformer`. And `FilterTransformer` is the
second transformer of `CompositeTransformer`. I think we should put this
predicate in the for loop. Could you help review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
