swaminathanmanish commented on code in PR #12115:
URL: https://github.com/apache/pinot/pull/12115#discussion_r1423311235
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/TableConfigPartitioner.java:
##########
@@ -41,6 +43,16 @@ public TableConfigPartitioner(String columnName,
ColumnPartitionConfig columnPar
@Override
public String getPartition(GenericRow genericRow) {
- return
String.valueOf(_partitionFunction.getPartition(genericRow.getValue(_column)));
+ return
String.valueOf(_partitionFunction.getPartition(convertToString(genericRow.getValue(_column))));
+ }
+
+ private static String convertToString(Object value) {
Review Comment:
Ok sounds good. I assume that if a new type is introduced, we anyway have to
modify RequestContextUtils to add the new literal type? (where the exception is
thrown). if thats the case, we can consider moving this logic and the one in
MutableSegmentImpl.java to RequestContextUtils, so that they are in the same
file and easy to discover all the places that needs the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
