Jackie-Jiang commented on code in PR #12135:
URL: https://github.com/apache/pinot/pull/12135#discussion_r1423137832
##########
pinot-core/src/main/java/org/apache/pinot/core/util/OsCheck.java:
##########
@@ -46,9 +48,11 @@ public enum OSType {
Windows, MacOS, Linux, Other
}
+ private static final Logger log = LoggerFactory.getLogger(OsCheck.class);
Review Comment:
(convention) Use all uppercase for static final fields, suggest also fixing
`_detectedOS` to `DETECTED_OS` or `OS_TYPE`
```suggestion
private static final Logger LOGGER =
LoggerFactory.getLogger(OsCheck.class);
```
##########
pinot-core/src/main/java/org/apache/pinot/core/util/OsCheck.java:
##########
@@ -46,9 +48,11 @@ public enum OSType {
Windows, MacOS, Linux, Other
}
+ private static final Logger log = LoggerFactory.getLogger(OsCheck.class);
+
static {
String os = System.getProperty("os.name",
"generic").toLowerCase(Locale.ENGLISH);
- System.out.println(os);
+ log.info("System property \"os.name\" is [{}]", os);
Review Comment:
@jasperjiaguo Is this print intentional?
(minor, convention)
```suggestion
log.info("System property \"os.name\" is: {}", os);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
