Jackie-Jiang commented on issue #12111: URL: https://github.com/apache/pinot/issues/12111#issuecomment-1851057424
This is a great optimization! Ideally we should provide a mapping from query `AggregationFunctionType` to aggregator `AggregationFunctionType`, which is already happening implicitly under `ValueAggregatorFactory`. If we make this mapping explicit, we can always store the aggregator type in the metadata (for backward compatibility, we can do a map lookup when loading the metadata), and when solving queries, we lookup the mapping again to search for the function. IMO this way is easier to manage comparing to introducing the "virtual" function concept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
