[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8669: Change minion's default port, enable minion health and readiness probe via helm chart

saurabhd336 commented on code in PR #8669: URL: https://github.com/apache/pinot/pull/8669#discussion_r869915450 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -527,7 +527,7 @@ public static class Minion { public static final String CONFIG_

[GitHub] [pinot] codecov-commenter commented on pull request #8682: By default start 1 minion for all quickstart

codecov-commenter commented on PR #8682: URL: https://github.com/apache/pinot/pull/8682#issuecomment-1123216157 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8682?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] xiangfu0 opened a new pull request, #8682: By default start 1 minion for all quickstart

xiangfu0 opened a new pull request, #8682: URL: https://github.com/apache/pinot/pull/8682 So it's simpler for users to play around with minion related features -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pinot] saurabhd336 commented on pull request #8663: Segment resume API

saurabhd336 commented on PR #8663: URL: https://github.com/apache/pinot/pull/8663#issuecomment-1123200743 @sajjad-moradi I had a discussion with @npawar on this, and seems like this functionality addresses issues arising due to accidental deletion of consuming segments, and therefore its av

[pinot] branch master updated: Amend schema to add timestamp index during segment reloading (#8679)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a12b760b74 Amend schema to add timestamp index d

[GitHub] [pinot] xiangfu0 merged pull request #8679: [bugfix] Amend schema to add timestamp index during segment reloading

xiangfu0 merged PR #8679: URL: https://github.com/apache/pinot/pull/8679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] codecov-commenter commented on pull request #8677: Upgrade jersay to fix parallel segment upload

codecov-commenter commented on PR #8677: URL: https://github.com/apache/pinot/pull/8677#issuecomment-1123095325 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] codecov-commenter commented on pull request #8681: Add InstanceTypeUtils to get instance type from the id

codecov-commenter commented on PR #8681: URL: https://github.com/apache/pinot/pull/8681#issuecomment-1123076244 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8681?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[pinot] branch master updated: Add BigDecimal OnHeap/OffHeap mutable dictionaries (#8678)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d616a097e5 Add BigDecimal OnHeap/OffHeap mutable

[GitHub] [pinot] Jackie-Jiang merged pull request #8678: Add BigDecimal OnHeap/OffHeap mutable dictionaries

Jackie-Jiang merged PR #8678: URL: https://github.com/apache/pinot/pull/8678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] codecov-commenter commented on pull request #8678: Add BigDecimal OnHeap/OffHeap mutable dictionaries

codecov-commenter commented on PR #8678: URL: https://github.com/apache/pinot/pull/8678#issuecomment-1123046851 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8678?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] siddharthteotia commented on pull request #8680: [bugfix] Explain plan improvements

siddharthteotia commented on PR #8680: URL: https://github.com/apache/pinot/pull/8680#issuecomment-1123046297 By mistake got created against master. Let's first iterate upon it and discuss and then create a PR -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pinot] siddharthteotia closed pull request #8680: [bugfix] Explain plan improvements

siddharthteotia closed pull request #8680: [bugfix] Explain plan improvements URL: https://github.com/apache/pinot/pull/8680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] codecov-commenter commented on pull request #8679: [bugfix] Amend schema to add timestamp index during segment reloading

codecov-commenter commented on PR #8679: URL: https://github.com/apache/pinot/pull/8679#issuecomment-1123044677 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] somandal opened a new pull request, #8680: [bugfix] Explain plan improvements

somandal opened a new pull request, #8680: URL: https://github.com/apache/pinot/pull/8680 Improve the accuracy of the Explain plan output. Today Explain plan selects a single segment to send the request to on the Server side. This segment may be pruned on the server side or may not match th

[GitHub] [pinot] klsince commented on issue #8222: OfflineClusterIntegrationTest.testInvertedIndexTriggering is flaky

klsince commented on issue #8222: URL: https://github.com/apache/pinot/issues/8222#issuecomment-1123037058 will look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[pinot] branch master updated: refine error msg related to segment name generation to be more actionable (#8676)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5135acb95d refine error msg related to segment na

[GitHub] [pinot] Jackie-Jiang merged pull request #8676: refine error msg related to segment name generation

Jackie-Jiang merged PR #8676: URL: https://github.com/apache/pinot/pull/8676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

Jackie-Jiang commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869768587 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3396,6 +3398,42 @@ private void updateSegmentLineageEn

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

Jackie-Jiang commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869768432 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3396,6 +3398,42 @@ private void updateSegmentLineageEn

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

Jackie-Jiang commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869768041 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3381,19 +3384,40 @@ public void revertReplaceSegments(

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8679: [bugfix] Amend schema to add timestamp index during segment reloading

Jackie-Jiang commented on code in PR #8679: URL: https://github.com/apache/pinot/pull/8679#discussion_r869765652 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java: ## @@ -158,6 +158,11 @@ public static Immutabl

[GitHub] [pinot] Jackie-Jiang commented on issue #8222: OfflineClusterIntegrationTest.testInvertedIndexTriggering is flaky

Jackie-Jiang commented on issue #8222: URL: https://github.com/apache/pinot/issues/8222#issuecomment-1123026351 @klsince Please take a look at this test and see if it still applies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pinot] Jackie-Jiang commented on issue #8212: UpsertTableSegmentUploadIntegrationTest.testSegmentAssignment is flaky

Jackie-Jiang commented on issue #8212: URL: https://github.com/apache/pinot/issues/8212#issuecomment-1123025248 Duplicate with #8532, fixed in #8675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pinot] Jackie-Jiang closed issue #8212: UpsertTableSegmentUploadIntegrationTest.testSegmentAssignment is flaky

Jackie-Jiang closed issue #8212: UpsertTableSegmentUploadIntegrationTest.testSegmentAssignment is flaky URL: https://github.com/apache/pinot/issues/8212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] xiangfu0 opened a new pull request, #8679: [bugfix] Amend schema to add timestamp index during segment reloading

xiangfu0 opened a new pull request, #8679: URL: https://github.com/apache/pinot/pull/8679 Currently, the Timestamp index got dropped when the servers restart or segments reload from the disk. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [pinot] jtao15 commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jtao15 commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869761154 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3353,7 +3355,8 @@ public void revertReplaceSegments(String

[GitHub] [pinot] nizarhejazi opened a new pull request, #8678: Add BigDecimal OnHeap/OffHeap mutable dictionaries

nizarhejazi opened a new pull request, #8678: URL: https://github.com/apache/pinot/pull/8678 - Add BigDecimal OnHeap/OffHeap mutable dictionaries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] codecov-commenter commented on pull request #8676: refine error msg related to segment name generation

codecov-commenter commented on PR #8676: URL: https://github.com/apache/pinot/pull/8676#issuecomment-1123009882 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8676?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang closed issue #8218: MergeRollupMinionClusterIntegrationTest is flaky

Jackie-Jiang closed issue #8218: MergeRollupMinionClusterIntegrationTest is flaky URL: https://github.com/apache/pinot/issues/8218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pinot] Jackie-Jiang commented on issue #8218: MergeRollupMinionClusterIntegrationTest is flaky

Jackie-Jiang commented on issue #8218: URL: https://github.com/apache/pinot/issues/8218#issuecomment-1123006479 The root cause is the same as #8265. Closing this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #8677: Upgrade jersay to fix parallel segment upload

Jackie-Jiang opened a new pull request, #8677: URL: https://github.com/apache/pinot/pull/8677 Caught by #8265 The root cause is a bug in the `metro-mimepull` library Upgrade jersey to the latest commonly used version to include the fix Note that the current jersey version has [

[GitHub] [pinot] Jackie-Jiang commented on issue #8265: [Flaky test] Failed to upload segments in integration tests

Jackie-Jiang commented on issue #8265: URL: https://github.com/apache/pinot/issues/8265#issuecomment-1122992889 This is caused by a bug in the `metro-mimepull` library: https://github.com/eclipse-ee4j/metro-mimepull/issues/11 -- This is an automated message from the Apache Git Service. To

[GitHub] [pinot] klsince opened a new pull request, #8676: refine error msg related to segment name generation

klsince opened a new pull request, #8676: URL: https://github.com/apache/pinot/pull/8676 refine error msg related to segment name generation to be more actionable, particularly with more context info to help figure out which name generator type should be used -- This is an automated mess

[GitHub] [pinot] jtao15 commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jtao15 commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869721248 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3381,19 +3384,40 @@ public void revertReplaceSegments(String

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

Jackie-Jiang commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869703942 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3381,19 +3384,40 @@ public void revertReplaceSegments(

[GitHub] [pinot] Jackie-Jiang commented on issue #8641: "Failed to generate Pinot segment for file" didn't throw an exception

Jackie-Jiang commented on issue #8641: URL: https://github.com/apache/pinot/issues/8641#issuecomment-1122898428 @kkrugler IMO we should definitely fail the task if some segments are not properly generated. If we only log some warning/error but let the task succeed, very likely user will

[GitHub] [pinot] jtao15 commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jtao15 commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869696463 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(String

[GitHub] [pinot] siddharthteotia merged pull request #8583: Introduce column/row/metadata block for data transfer between stages

siddharthteotia merged PR #8583: URL: https://github.com/apache/pinot/pull/8583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[pinot] branch multi_stage_query_engine updated: row/columnar compatible block (#8583)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/multi_stage_query_engine by this push: new 77b59bf9

[GitHub] [pinot] jackjlli commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jackjlli commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869695417 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(Stri

[GitHub] [pinot] jtao15 commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jtao15 commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869693925 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(String

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

Jackie-Jiang commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869693929 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(

[GitHub] [pinot] Jackie-Jiang merged pull request #8675: Fix the flaky UpsertTableSegmentUploadIntegrationTest

Jackie-Jiang merged PR #8675: URL: https://github.com/apache/pinot/pull/8675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated: Fix the flaky UpsertTableSegmentUploadIntegrationTest (#8675)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f4c85e9596 Fix the flaky UpsertTableSegmentUpload

[GitHub] [pinot] Jackie-Jiang closed issue #8532: UpsertTableSegmentUploadIntegrationTest.testSegmentAssignment:190

Jackie-Jiang closed issue #8532: UpsertTableSegmentUploadIntegrationTest.testSegmentAssignment:190 URL: https://github.com/apache/pinot/issues/8532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pinot] jackjlli commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jackjlli commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869674942 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(Stri

[GitHub] [pinot] mneedham commented on pull request #8673: Import dry run

mneedham commented on PR #8673: URL: https://github.com/apache/pinot/pull/8673#issuecomment-1122855034 @KKcorps yeh I can add the schema file as an optional parameter. I did actually have it in there initially but realised that you don't actually require it to transform the fields -- Thi

[GitHub] [pinot] jackjlli commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

jackjlli commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869674942 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(Stri

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8653: Allow updating start/end offset for pushed segments

Jackie-Jiang commented on code in PR #8653: URL: https://github.com/apache/pinot/pull/8653#discussion_r869672337 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/ZKMetadataUtils.java: ## @@ -20,58 +20,106 @@ import java.util.HashMap; import java.

[GitHub] [pinot] KKcorps commented on a diff in pull request #8674: Remove segments using valid doc ids instead of primary key

KKcorps commented on code in PR #8674: URL: https://github.com/apache/pinot/pull/8674#discussion_r869667236 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java: ## @@ -246,13 +251,18 @@ public void removeSegment(IndexSeg

[pinot] branch master updated (abf62f571d -> 65cecd259e)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from abf62f571d fix pruning in expressions by max/min/bloom (#8672) add 65cecd259e Randomly pick the first URI for RoundR

[GitHub] [pinot] jackjlli merged pull request #8666: Randomly pick the first URI for RoundRobinURIProvider

jackjlli merged PR #8666: URL: https://github.com/apache/pinot/pull/8666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] KKcorps commented on a diff in pull request #8674: Remove segments using valid doc ids instead of primary key

KKcorps commented on code in PR #8674: URL: https://github.com/apache/pinot/pull/8674#discussion_r869662199 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java: ## @@ -246,13 +251,18 @@ public void removeSegment(IndexSeg

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8663: Segment resume API

Jackie-Jiang commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r869650400 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -701,7 +702,7 @@ private void createNewSe

[GitHub] [pinot] siddharthteotia commented on issue #8618: Query Processing Resiliency

siddharthteotia commented on issue #8618: URL: https://github.com/apache/pinot/issues/8618#issuecomment-1122803861 @vvivekiyer has code changes / prototype in progress along with adding those concrete details to the design doc for server selection. Will share for review soon -- This is

[GitHub] [pinot] siddharthteotia commented on issue #8607: Explain plan can be misleading

siddharthteotia commented on issue #8607: URL: https://github.com/apache/pinot/issues/8607#issuecomment-1122802400 Change is in progress -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #8653: Allow updating start/end offset for pushed segments

sajjad-moradi commented on code in PR #8653: URL: https://github.com/apache/pinot/pull/8653#discussion_r869624998 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/ZKMetadataUtils.java: ## @@ -20,58 +20,106 @@ import java.util.HashMap; import java

[GitHub] [pinot] codecov-commenter commented on pull request #8675: Fix the flaky UpsertTableSegmentUploadIntegrationTest

codecov-commenter commented on PR #8675: URL: https://github.com/apache/pinot/pull/8675#issuecomment-1122787432 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8675?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8674: Remove segments using valid doc ids instead of primary key

Jackie-Jiang commented on code in PR #8674: URL: https://github.com/apache/pinot/pull/8674#discussion_r869591842 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java: ## @@ -246,13 +251,18 @@ public void removeSegment(Ind

[GitHub] [pinot] Jackie-Jiang merged pull request #8672: fix pruning in expressions by max/min/bloom

Jackie-Jiang merged PR #8672: URL: https://github.com/apache/pinot/pull/8672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch randomly-pick-endpoint updated (39f40f8e14 -> ce29ec2825)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch randomly-pick-endpoint in repository https://gitbox.apache.org/repos/asf/pinot.git discard 39f40f8e14 Randomly pick the first URI for RoundRobinURIProvider add ce29ec2825 Randomly pick the fi

[pinot] branch master updated (d208f577ed -> abf62f571d)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from d208f577ed Adding pinot file system command (#8659) add abf62f571d fix pruning in expressions by max/min/bloom (#8

[GitHub] [pinot] Jackie-Jiang closed issue #8671: Pinot is not pruning some`in` expressions when it can

Jackie-Jiang closed issue #8671: Pinot is not pruning some`in` expressions when it can URL: https://github.com/apache/pinot/issues/8671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] Jackie-Jiang commented on pull request #8672: fix pruning in expressions by max/min/bloom

Jackie-Jiang commented on PR #8672: URL: https://github.com/apache/pinot/pull/8672#issuecomment-1122752607 > It might be my misunderstanding, but why would there be a situation that data source indicates a min/max value between `(5, 10)`, yet the same datasource bloom filter suggest it can

[pinot] branch master updated: Adding pinot file system command (#8659)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d208f577ed Adding pinot file system command (#86

[GitHub] [pinot] xiangfu0 merged pull request #8659: Adding pinot file system command

xiangfu0 merged PR #8659: URL: https://github.com/apache/pinot/pull/8659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

Jackie-Jiang commented on code in PR #8667: URL: https://github.com/apache/pinot/pull/8667#discussion_r869576260 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3132,8 +3132,20 @@ public String startReplaceSegments(

[GitHub] [pinot] jackjlli commented on a diff in pull request #8666: Randomly pick the first URI for RoundRobinURIProvider

jackjlli commented on code in PR #8666: URL: https://github.com/apache/pinot/pull/8666#discussion_r869572957 ## pinot-common/src/test/java/org/apache/pinot/common/utils/RoundRobinURIProviderTest.java: ## @@ -50,128 +52,135 @@ public void testHostAddressRoundRobin() mock.whe

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8653: Allow updating start/end offset for pushed segments

Jackie-Jiang commented on code in PR #8653: URL: https://github.com/apache/pinot/pull/8653#discussion_r869568425 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/ZKMetadataUtils.java: ## @@ -20,58 +20,106 @@ import java.util.HashMap; import java.

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #8675: Fix the flaky UpsertTableSegmentUploadIntegrationTest

Jackie-Jiang opened a new pull request, #8675: URL: https://github.com/apache/pinot/pull/8675 Fix #8532 Also clean up the segment upload helper function to allow uploading realtime segments -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #8653: Allow updating start/end offset for pushed segments

sajjad-moradi commented on code in PR #8653: URL: https://github.com/apache/pinot/pull/8653#discussion_r869500732 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/ZKMetadataUtils.java: ## @@ -20,58 +20,106 @@ import java.util.HashMap; import java

[GitHub] [pinot] kkrugler commented on issue #8641: "Failed to generate Pinot segment for file" didn't throw an exception

kkrugler commented on issue #8641: URL: https://github.com/apache/pinot/issues/8641#issuecomment-1122687034 @Jackie-Jiang - that does seem much cleaner. When you say `fail the task with all the failed segments returned` are you saying the thrown exception should contain a message with

[GitHub] [pinot] saurabhd336 closed pull request #8651: Fix minion health check endpoint

saurabhd336 closed pull request #8651: Fix minion health check endpoint URL: https://github.com/apache/pinot/pull/8651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8669: Change minion's default port, enable minion health and readiness probe via helm chart

Jackie-Jiang commented on code in PR #8669: URL: https://github.com/apache/pinot/pull/8669#discussion_r869491638 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -527,7 +527,7 @@ public static class Minion { public static final String CONFIG

[GitHub] [pinot] atris merged pull request #8636: Introduce Real Time Native Text Index

atris merged PR #8636: URL: https://github.com/apache/pinot/pull/8636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.o

[pinot] branch master updated: Introduce Real Time Native Text Index (#8636)

This is an automated email from the ASF dual-hosted git repository. atri pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 497d0517ab Introduce Real Time Native Text Index (#

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8666: Randomly pick the first URI for RoundRobinURIProvider

Jackie-Jiang commented on code in PR #8666: URL: https://github.com/apache/pinot/pull/8666#discussion_r869448228 ## pinot-common/src/test/java/org/apache/pinot/common/utils/RoundRobinURIProviderTest.java: ## @@ -50,128 +52,135 @@ public void testHostAddressRoundRobin() mock

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8654: Support ADLS authentication with AAD + proxy

vvivekiyer commented on code in PR #8654: URL: https://github.com/apache/pinot/pull/8654#discussion_r869448335 ## pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java: ## @@ -128,21 +148,54 @@ public void init(PinotConf

[GitHub] [pinot] Jackie-Jiang commented on pull request #8636: Introduce Real Time Native Text Index

Jackie-Jiang commented on PR #8636: URL: https://github.com/apache/pinot/pull/8636#issuecomment-1122597936 > Regards to the Analyser, I looked at the core Lucene class and also did some benchmarking -- due to the fact that only one thread is writing to a single mutable FST at any given poin

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8636: Introduce Real Time Native Text Index

Jackie-Jiang commented on code in PR #8636: URL: https://github.com/apache/pinot/pull/8636#discussion_r869423892 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/NativeAndLuceneMutableTextIndexTest.java: ## @@ -0,0 +1,107 @@ +/** +

[GitHub] [pinot] suddendust commented on pull request #8658: CSV Realtime Decoder

suddendust commented on PR #8658: URL: https://github.com/apache/pinot/pull/8658#issuecomment-1122483356 @Jackie-Jiang Requesting re-review, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] codecov-commenter commented on pull request #8674: Remove segments using valid doc ids instead of primary key

codecov-commenter commented on PR #8674: URL: https://github.com/apache/pinot/pull/8674#issuecomment-1122411540 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Segment resume API

saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r869242329 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentStateResource.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Segment resume API

saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r869241910 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentStateResource.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Segment resume API

saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r869241337 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentStateResource.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] KKcorps commented on pull request #8674: Remove segments using valid doc ids instead of primary key

KKcorps commented on PR #8674: URL: https://github.com/apache/pinot/pull/8674#issuecomment-1122353725 @Jackie-Jiang Should we store primary key columns in segment metadata as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pinot] KKcorps opened a new pull request, #8674: Remove segments using valid doc ids instead of primary key

KKcorps opened a new pull request, #8674: URL: https://github.com/apache/pinot/pull/8674 This PR improves the performance segment removal from upsert metadata. Currently, we iterate upon whole state to check for matching primary keys to doc ids in segment. We can improve this by iterating u

[GitHub] [pinot] KKcorps commented on pull request #8673: Import dry run

KKcorps commented on PR #8673: URL: https://github.com/apache/pinot/pull/8673#issuecomment-1122277471 Is it also possible to add schema as an option to this? There are a few cases where schema also interferes with transform values. I have run into such errors when using `JSON` field in sche

[GitHub] [pinot] codecov-commenter commented on pull request #8673: Import dry run

codecov-commenter commented on PR #8673: URL: https://github.com/apache/pinot/pull/8673#issuecomment-1122276744 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8673?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] KKcorps commented on pull request #8672: fix pruning in expressions by max/min/bloom

KKcorps commented on PR #8672: URL: https://github.com/apache/pinot/pull/8672#issuecomment-1122215557 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pinot] mneedham opened a new pull request, #8673: Import dry run

mneedham opened a new pull request, #8673: URL: https://github.com/apache/pinot/pull/8673 When I'm working with nested JSON documents it's a bit difficult to figure out exactly what the end result of a batch/streaming ingestion is gonna be, especially if you're using `complexConfig` or tran

[GitHub] [pinot] stym06 commented on pull request #8661: add datetimefield json constr

stym06 commented on PR #8661: URL: https://github.com/apache/pinot/pull/8661#issuecomment-1122208430 Acknowledged. Let me see -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] codecov-commenter commented on pull request #8670: Support pluggable auth provider

codecov-commenter commented on PR #8670: URL: https://github.com/apache/pinot/pull/8670#issuecomment-1122150383 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8670?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] gortiz opened a new pull request, #8672: fix pruning in expressions by max/min/bloom

gortiz opened a new pull request, #8672: URL: https://github.com/apache/pinot/pull/8672 This PR fixes #8671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pinot] gortiz opened a new issue, #8671: Pinot is not pruning some`in` expressions when it can

gortiz opened a new issue, #8671: URL: https://github.com/apache/pinot/issues/8671 By reading this test, is clear that there are some cases where Pinot is not pruning expressions it can prune. Specifically: 1. If all values are outside the max/min range but at least one was in the bl

[pinot] branch pinot-flexible-auth-provider updated (3d5f10c2f8 -> 15acfde711)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch pinot-flexible-auth-provider in repository https://gitbox.apache.org/repos/asf/pinot.git from 3d5f10c2f8 test cleanup add 15acfde711 review cleanup No new revisions were added by this

[GitHub] [pinot] apucher opened a new pull request, #8670: Support pluggable auth provider

apucher opened a new pull request, #8670: URL: https://github.com/apache/pinot/pull/8670 This PR adds support for a pluggable client auth providers which enables pinot components (controller, server, minion) to use dynamically changing tokens such as kubernetes service account JWTs. The imp

[pinot] 02/02: test cleanup

This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch pinot-flexible-auth-provider in repository https://gitbox.apache.org/repos/asf/pinot.git commit 3d5f10c2f83e26b12a9b6b0d574ad32211b0 Author: Alexander Pucher AuthorDate: Tue May 10 01:11:24

[pinot] branch pinot-flexible-auth-provider updated (8ecba358ca -> 3d5f10c2f8)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch pinot-flexible-auth-provider in repository https://gitbox.apache.org/repos/asf/pinot.git from 8ecba358ca auth provider round 2 new 829995430b integration test new 3d5f10c2f8 test c

  1   2   >