Jackie-Jiang commented on code in PR #8669:
URL: https://github.com/apache/pinot/pull/8669#discussion_r869491638
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -527,7 +527,7 @@ public static class Minion {
public static final String CONFIG_OF_TASK_AUTH_TOKEN = "task.auth.token";
public static final String CONFIG_OF_ADMIN_API_PORT =
"pinot.minion.adminapi.port";
public static final String MINION_TLS_PREFIX = "pinot.minion.tls";
- public static final int DEFAULT_ADMIN_API_PORT = 6500;
+ public static final int DEFAULT_ADMIN_API_PORT = 9514;
Review Comment:
We should remove this config completely. We don't need a separate admin port
for minion, but use the regular port (similar to controller and broker. Server
is slightly different and has both query port and admin port).
You may take a look at the `ListenerConfigUtil` and modify the
`buildMinionAdminConfigs()` to be similar to `buildControllerConfigs()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
