[GitHub] [pinot] jtao15 commented on a diff in pull request #8667: Handle the race condition for common dest segments in startReplaceSegments()

[GitBox]

jtao15 commented on code in PR #8667:
URL: https://github.com/apache/pinot/pull/8667#discussion_r869693925


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3132,8 +3132,20 @@ public String startReplaceSegments(String 
tableNameWithType, List<String> segmen
               // Update segment lineage entry to 'REVERTED'
               updateSegmentLineageEntryToReverted(tableNameWithType, 
segmentLineage, entryId, lineageEntry);
 
+              // Update segmentsTo of the 'REVERTED' entry to handle the 
following case:

Review Comment:
   @jackjlli I think @Jackie-Jiang means we can remove the `IN_PROGRESS` entry 
if the segmentsTo are exactly the same.
   Say the initial state is:
   entry1: { segmentsFrom: [s1, s2], segmentsTo: [s3, s4], status: IN_PROGRESS}
   Rerunning the protocol with same segmentsTo will remove entry1 and create 
entry2:
   entry2: { segmentsFrom: [s1, s2], segmentsTo: [s3, s4], status: IN_PROGRESS}
   
   Even if s3 and s4 are not deleted, they will be filtered out based on entry2.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org