Jackie-Jiang commented on code in PR #8679: URL: https://github.com/apache/pinot/pull/8679#discussion_r869765652
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java: ########## @@ -158,6 +158,11 @@ public static ImmutableSegment load(SegmentDirectory segmentDirectory, IndexLoad return new EmptyIndexSegment(segmentMetadata); } + if (schema != null) { + schema = SegmentGeneratorConfig.updateSchemaWithTimestampIndexes(schema, + SegmentGeneratorConfig.extractTimestampIndexConfigsFromTableConfig(indexLoadingConfig.getTableConfig())); Review Comment: (minor) Move these 2 lines into the if check on line 168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org