Jackie-Jiang commented on code in PR #8666:
URL: https://github.com/apache/pinot/pull/8666#discussion_r869448228
##########
pinot-common/src/test/java/org/apache/pinot/common/utils/RoundRobinURIProviderTest.java:
##########
@@ -50,128 +52,135 @@ public void testHostAddressRoundRobin()
mock.when(() ->
InetAddress.getAllByName("testweb.com")).thenReturn(testWebAddresses);
TestCase[] testCases = new TestCase[]{
- new TestCase("http://127.0.0.1";, new String[]{"http://127.0.0.1"}),
- new TestCase("http://127.0.0.1/";, new String[]{"http://127.0.0.1/"}),
- new TestCase("http://127.0.0.1/?";, new String[]{"http://127.0.0.1/?"}),
- new TestCase("http://127.0.0.1/?it=5";, new
String[]{"http://127.0.0.1/?it=5"}),
- new TestCase("http://127.0.0.1/me/out?it=5";, new
String[]{"http://127.0.0.1/me/out?it=5"}),
- new TestCase("http://127.0.0.1:20000";, new
String[]{"http://127.0.0.1:20000"}),
- new TestCase("http://127.0.0.1:20000/";, new
String[]{"http://127.0.0.1:20000/"}),
- new TestCase("http://127.0.0.1:20000/?";, new
String[]{"http://127.0.0.1:20000/?"}),
- new TestCase("http://127.0.0.1:20000/?it=5";, new
String[]{"http://127.0.0.1:20000/?it=5"}),
- new TestCase("http://127.0.0.1:20000/me/out?it=5";, new
String[]{"http://127.0.0.1:20000/me/out?it=5"}),
+ new TestCase("http://127.0.0.1";, Arrays.asList("http://127.0.0.1";)),
Review Comment:
Why changing this? I do get an IDE warning when using `Arrays.asList` on
single element
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
