Jackie-Jiang commented on code in PR #8667:
URL: https://github.com/apache/pinot/pull/8667#discussion_r869693929
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3132,8 +3132,20 @@ public String startReplaceSegments(String
tableNameWithType, List<String> segmen
// Update segment lineage entry to 'REVERTED'
updateSegmentLineageEntryToReverted(tableNameWithType,
segmentLineage, entryId, lineageEntry);
+ // Update segmentsTo of the 'REVERTED' entry to handle the
following case:
Review Comment:
We can remove the old `IN_PROGRESS` entry only when all the `segmentsTo` are
covered by the new `IN_PROGRESS` entry, thus none of these segments will be
queryable. If that's not the case, we make it `REVERTED` and remove the common
segments from the `segmentsTo` (the current logic in the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
