kkrugler commented on issue #8641: URL: https://github.com/apache/pinot/issues/8641#issuecomment-1122687034
@Jackie-Jiang - that does seem much cleaner. When you say `fail the task with all the failed segments returned` are you saying the thrown exception should contain a message with a list of all failed segment names? Also should the fix for override disallowed (a) be a separate issue/PR, and (b) would you expect that the job would still fail, regardless of the new `terminateOnFailure` flag? If so then that would be a change in behavior, I wonder if anyone is relying on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
