[GitHub] [pinot] codecov-commenter edited a comment on pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8367: URL: https://github.com/apache/pinot/pull/8367#issuecomment-1072075697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-17 Thread GitBox
codecov-commenter commented on pull request #8367: URL: https://github.com/apache/pinot/pull/8367#issuecomment-1072075697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] Jackie-Jiang opened a new pull request #8367: Fix the flakiness of MultiNodesOfflineClusterIntegrationTest

2022-03-17 Thread GitBox
Jackie-Jiang opened a new pull request #8367: URL: https://github.com/apache/pinot/pull/8367 Fix #8324 The flakiness is caused by the following race condition: - The broker is removed from the IdealState - The broker is dropped from the cluster - The state transition message

[GitHub] [pinot] Jackie-Jiang commented on pull request #8331: Support NOT LIKE and NOT BETWEEN

2022-03-17 Thread GitBox
Jackie-Jiang commented on pull request #8331: URL: https://github.com/apache/pinot/pull/8331#issuecomment-1072022674 Related to #7701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8329: URL: https://github.com/apache/pinot/pull/8329#issuecomment-1063683490 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8329: URL: https://github.com/apache/pinot/pull/8329#issuecomment-1063683490 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] egalpin commented on issue #8353: Provide a way to group by an entire multi value field

2022-03-17 Thread GitBox
egalpin commented on issue #8353: URL: https://github.com/apache/pinot/issues/8353#issuecomment-1071971565 You might be able to achieve this behaviour today using Ingestion Transforms. If you had a transform which sorted (depending on whether order of values matters in your use case) the e

[GitHub] [pinot] INNOCENT-BOY commented on a change in pull request #8314: Access Control management Development

2022-03-17 Thread GitBox
INNOCENT-BOY commented on a change in pull request #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r822653032 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/user/ComponentType.java ## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] INNOCENT-BOY commented on a change in pull request #8314: Access Control management Development

2022-03-17 Thread GitBox
INNOCENT-BOY commented on a change in pull request #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r828006135 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1268,6 +1274,32 @@ public Sc

[GitHub] [pinot] INNOCENT-BOY commented on a change in pull request #8314: Access Control management Development

2022-03-17 Thread GitBox
INNOCENT-BOY commented on a change in pull request #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r827826870 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java ## @@ -93,4 +93,21 @@ public void validate

[GitHub] [pinot] INNOCENT-BOY commented on a change in pull request #8314: Access Control management Development

2022-03-17 Thread GitBox
INNOCENT-BOY commented on a change in pull request #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r829641115 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/provider/UserCache.java ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache S

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8366: Fix the missing NOT handling

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8366: URL: https://github.com/apache/pinot/pull/8366#issuecomment-1071936916 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] walterddr commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
walterddr commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829633997 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String sto

[GitHub] [pinot] codecov-commenter commented on pull request #8366: Fix the missing NOT handling

2022-03-17 Thread GitBox
codecov-commenter commented on pull request #8366: URL: https://github.com/apache/pinot/pull/8366#issuecomment-1071936916 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] Jackie-Jiang opened a new pull request #8366: Fix the missing NOT handling

2022-03-17 Thread GitBox
Jackie-Jiang opened a new pull request #8366: URL: https://github.com/apache/pinot/pull/8366 NOT filter is recently supported in #7701, but we missed several places where NOT is not properly handled -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pinot] codecov-commenter commented on pull request #8365: Use netty-bom to keep the netty-related libraries sync

2022-03-17 Thread GitBox
codecov-commenter commented on pull request #8365: URL: https://github.com/apache/pinot/pull/8365#issuecomment-1071906939 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1013577523 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] jasperjiaguo opened a new pull request #8365: Use netty-bom to keep the netty-related libraries sync

2022-03-17 Thread GitBox
jasperjiaguo opened a new pull request #8365: URL: https://github.com/apache/pinot/pull/8365 Netty related libraries (`netty-tcnative-boringssl-static`, `netty-transport-native-unix-common`, `netty-transport-native-epoll`, `netty-transport-native-kqueue`, etc.) needs be in sync with `nett

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829582532 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java ## @@ -162,8 +163,7 @@ public String get

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829580728 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapFillProcessor.java ## @@ -0,0 +1,455 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829578276 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -119,4 +137,265 @@ static public Serializable getDefaultValue

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829578012 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -133,6 +137,8 @@ private QueryContext(String

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8264: Add support for IS NULL and NOT IS NULL in transform functions

2022-03-17 Thread GitBox
codecov-commenter commented on pull request #8264: URL: https://github.com/apache/pinot/pull/8264#issuecomment-1071747264 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8264?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
dongxiaoman commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829555011 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java ## @@ -25,18 +25,16 @@ impor

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829543582 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -119,4 +137,265 @@ static public Serializable getDefaultValue

[GitHub] [pinot] richardstartin commented on a change in pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829540624 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/Fixtures.java ## @@ -67,8 +65,8 @@ private Fixtures()

[GitHub] [pinot] richardstartin commented on a change in pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829539859 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java ## @@ -25,18 +25,16 @@ im

[GitHub] [pinot] richardstartin commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829538546 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829536271 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -119,4 +137,265 @@ static public Serializable getDefaultValue

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829536104 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java ## @@ -71,12 +86,15 @@ public static boolean isFill(ExpressionContex

[GitHub] [pinot] richardstartin commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829535449 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] codecov-commenter commented on pull request #8364: Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
codecov-commenter commented on pull request #8364: URL: https://github.com/apache/pinot/pull/8364#issuecomment-1071540686 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829534730 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@ -42,23 +42,42

[GitHub] [pinot] richardstartin commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829533085 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(Strin

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829529037 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java ## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apac

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829527472 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java ## @@ -114,6 +115,7 @@ public AsyncQueryResponse submitQuery(lo

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829526920 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java ## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apac

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829526920 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java ## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apac

[GitHub] [pinot] dongxiaoman commented on pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
dongxiaoman commented on pull request #8364: URL: https://github.com/apache/pinot/pull/8364#issuecomment-1071514091 cc @npawar The PR for the follow up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
dongxiaoman commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829522463 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/Fixtures.java ## @@ -35,8 +33,8 @@ private Fixtures() {

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829521557 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StageNodeConverter.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829520375 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -391,6 +388,9 @@ public static DataTable

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829518555 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -88,6 +83,8 @@ private SelectionOperator

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829516324 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillFilterHandler.java ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
dongxiaoman commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829506556 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java ## @@ -25,18 +25,16 @@ impor

[GitHub] [pinot] kkrugler commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
kkrugler commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829506216 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -232,8 +235,7 @@ public static void installDefaultSSLSocketFact

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829496631 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/filter/ValueExtractorFactory.java ## @@ -0,0 +1,29 @@ +/** + * Licensed to th

[GitHub] [pinot] kkrugler commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
kkrugler commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829494766 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -60,6 +61,8 @@ private static final String TRUSTSTORE_PASSWO

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829494003 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/filter/RowMatcherFactory.java ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Ap

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829487992 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/filter/ValueExtractorFactory.java ## @@ -0,0 +1,29 @@ +/** + * Licensed to th

[GitHub] [pinot] kkrugler commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
kkrugler commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829485698 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829485246 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829483999 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] richardstartin commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829481022 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/Fixtures.java ## @@ -35,8 +33,8 @@ private Fixtures()

[GitHub] [pinot] richardstartin commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829480673 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java ## @@ -212,4

[GitHub] [pinot] richardstartin commented on a change in pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
richardstartin commented on a change in pull request #8364: URL: https://github.com/apache/pinot/pull/8364#discussion_r829480330 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java ## @@ -25,18 +25,16 @@ im

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829478960 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] dongxiaoman opened a new pull request #8364: [WIP] Refactor Segment creation to use TransformPipeline too

2022-03-17 Thread GitBox
dongxiaoman opened a new pull request #8364: URL: https://github.com/apache/pinot/pull/8364 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-incompat**

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829470251 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829464458 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@ -42,23 +42,42

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829469382 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829468126 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -375,6 +393,57 @@ public String toString() {

[pinot] branch master updated (f60bfc8 -> 360a205)

2022-03-17 Thread cpsoman
This is an automated email from the ASF dual-hosted git repository. cpsoman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from f60bfc8 Add support for Kinesis datasource in Github Events recipe (#8333) add 360a205 Add prefixesToRename c

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829463175 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -436,6 +505,11 @@ public Builder setBrokerRe

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829462749 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -375,6 +393,57 @@ public String toString() {

[GitHub] [pinot] icefury71 merged pull request #8273: Add prefixesToRename config for renaming fields upon ingestion

2022-03-17 Thread GitBox
icefury71 merged pull request #8273: URL: https://github.com/apache/pinot/pull/8273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829462309 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -85,6 +86,7 @@ // Keep the BrokerRequest

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829462208 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ## @@ -188,6 +194,10 @@ public FilterContext getHa

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829451951 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapFillProcessor.java ## @@ -0,0 +1,455 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829450123 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829448967 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ColumnDataToBlockValSetConverter.java ## @@ -0,0 +1,181 @@ +/** + * Licensed

[GitHub] [pinot] KKcorps commented on pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-17 Thread GitBox
KKcorps commented on pull request #8304: URL: https://github.com/apache/pinot/pull/8304#issuecomment-1071315988 @Jackie-Jiang @richardstartin I have added the unit-tests as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829447775 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -108,7 +108,12 @@ public BrokerResponseNative

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829440629 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -100,6 +95,9 @@ private CalciteSqlParser() { priva

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829440530 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -67,9 +67,7 @@ public class CalciteSqlParser { -

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829438895 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -2183,9 +2192,9 @@ private void att

[GitHub] [pinot] weixiangsun commented on a change in pull request #8029: Add Time-Series Gapfilling functionality.

2022-03-17 Thread GitBox
weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r829434243 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -217,6 +218,10 @@ private BrokerRes

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8304: URL: https://github.com/apache/pinot/pull/8304#issuecomment-1066731691 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829403274 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java ## @@ -0,0 +1,49 @@ +/** + * Licensed t

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829403274 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java ## @@ -0,0 +1,49 @@ +/** + * Licensed t

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829385895 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java ## @@ -0,0 +1,49 @@ +/** + * Licensed t

[pinot] branch master updated: Add support for Kinesis datasource in Github Events recipe (#8333)

2022-03-17 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f60bfc8 Add support for Kinesis datasource

[GitHub] [pinot] KKcorps merged pull request #8333: Add support for Kinesis datasource in Github Events recipe

2022-03-17 Thread GitBox
KKcorps merged pull request #8333: URL: https://github.com/apache/pinot/pull/8333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829300127 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] xiangfu0 commented on issue #6297: Adding Pinot Redash integration

2022-03-17 Thread GitBox
xiangfu0 commented on issue #6297: URL: https://github.com/apache/pinot/issues/6297#issuecomment-1071163899 0.3.3 is good with Pinot < 0.8. Pinot introduces new data types: TIMESTAMP/JSON after 0.8.0 The python client support is added here: [Changes](https://github.com/python-

[GitHub] [pinot] etadelta222 commented on issue #6297: Adding Pinot Redash integration

2022-03-17 Thread GitBox
etadelta222 commented on issue #6297: URL: https://github.com/apache/pinot/issues/6297#issuecomment-1071159036 Hi @xiangfu0 , I'm trying to get this open pr approved on Redash (https://github.com/getredash/redash/pull/5446). This query runner is compatible with which version of Pinot? --

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8304: Add commonly used math, string and date scalar functions in Pinot

2022-03-17 Thread GitBox
codecov-commenter edited a comment on pull request #8304: URL: https://github.com/apache/pinot/pull/8304#issuecomment-1066731691 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[pinot] 01/02: Update license & notice for release 0.10.0

2022-03-17 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit ac2c9a0362f481829772bede6fff43f4681be357 Author: Sajjad Moradi AuthorDate: Wed Mar 9 15:28:59 2022 -0800

[pinot] 02/02: Update the end date in notice file

2022-03-17 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit 08d0db1169c5d6466fdb9e769bc4c2a6ed456b59 Author: Sajjad Moradi AuthorDate: Thu Mar 10 11:38:56 2022 -0800

[pinot] branch release-0.10.0-rc created (now 08d0db1)

2022-03-17 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. at 08d0db1 Update the end date in notice file This branch includes the following new commits: new ac2c

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829306922 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/TableScanNode.java ## @@ -0,0 +1,57 @@ +/** + * Licensed to th

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8340: Add pinot-query-planner module

2022-03-17 Thread GitBox
siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829305909 ## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/TableScanNode.java ## @@ -0,0 +1,57 @@ +/** + * Licensed to th

[GitHub] [pinot] walterddr commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
walterddr commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829305394 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String sto

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829294078 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829289735 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java ## @@ -0,0 +1,371 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

2022-03-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #8329: URL: https://github.com/apache/pinot/pull/8329#discussion_r829288558 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java ## @@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8337: Fix bug when importing files with the same name in different directories

2022-03-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #8337: URL: https://github.com/apache/pinot/pull/8337#discussion_r829277096 ## File path: pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGen

  1   2   >