richardstartin commented on a change in pull request #8364:
URL: https://github.com/apache/pinot/pull/8364#discussion_r829481022
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/Fixtures.java
##########
@@ -35,8 +33,8 @@ private Fixtures() {
public static final int MAX_ROWS_IN_SEGMENT = 250000;
public static final long MAX_TIME_FOR_SEGMENT_CLOSE_MS = 64368000L;
public static final String TOPIC_NAME = "someTopic";
- public static final String CONSUMER_FACTORY_CLASS =
FakeStreamConsumerFactory.class.getName();
- public static final String MESSAGE_DECODER_CLASS =
FakeStreamMessageDecoder.class.getName();
+ public static final String CONSUMER_FACTORY_CLASS =
"some.consumer.factory.class";
+ public static final String MESSAGE_DECODER_CLASS =
"some.message.decoder.class";
Review comment:
why does this need to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
