siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r829529037
########## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java ########## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.calcite.rel.RelDistribution; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.RelRoot; +import org.apache.calcite.rel.logical.LogicalExchange; +import org.apache.pinot.query.context.PlannerContext; +import org.apache.pinot.query.planner.nodes.MailboxReceiveNode; +import org.apache.pinot.query.planner.nodes.MailboxSendNode; +import org.apache.pinot.query.planner.nodes.StageNode; +import org.apache.pinot.query.routing.WorkerManager; + + +/** + * QueryPlanMaker walks top-down from {@link RelRoot} and construct a forest of trees with {@link StageNode}. + * + * This class is non-threadsafe. Do not reuse the stage planner for multiple query plans. + */ +public class StagePlanner { + private final PlannerContext _plannerContext; + private final WorkerManager _workerManager; + + private Map<String, StageNode> _queryStageMap; + private Map<String, StageMetadata> _stageMetadataMap; + private int _stageIdCounter; + + public StagePlanner(PlannerContext plannerContext, WorkerManager workerManager) { + _plannerContext = plannerContext; + _workerManager = workerManager; + } + + public QueryPlan makePlan(RelNode relRoot) { + // clear the state + _queryStageMap = new HashMap<>(); + _stageMetadataMap = new HashMap<>(); + _stageIdCounter = 0; + + // walk the plan and create stages. + StageNode globalStageRoot = walkRelPlan(relRoot, getNewStageId()); + + // global root needs to send results back to the ROOT, a.k.a. the client response node. + // the last stage is always a broadcast-gather. + StageNode globalReceiverNode = + new MailboxReceiveNode("ROOT", globalStageRoot.getStageId(), RelDistribution.Type.BROADCAST_DISTRIBUTED); + StageNode globalSenderNode = new MailboxSendNode(globalStageRoot, globalReceiverNode.getStageId(), + RelDistribution.Type.BROADCAST_DISTRIBUTED); + _queryStageMap.put(globalSenderNode.getStageId(), globalSenderNode); + StageMetadata stageMetadata = _stageMetadataMap.get(globalSenderNode.getStageId()); + stageMetadata.attach(globalSenderNode); + + _queryStageMap.put(globalReceiverNode.getStageId(), globalReceiverNode); + StageMetadata globalReceivingStageMetadata = new StageMetadata(); + globalReceivingStageMetadata.attach(globalReceiverNode); + _stageMetadataMap.put(globalReceiverNode.getStageId(), globalReceivingStageMetadata); + + // assign workers to each stage. + for (Map.Entry<String, StageMetadata> e : _stageMetadataMap.entrySet()) { + _workerManager.assignWorkerToStage(e.getKey(), e.getValue()); + } + + return new QueryPlan(_queryStageMap, _stageMetadataMap); + } + + // non-threadsafe Review comment: I had a thread safety related question on QueryEnvironment. If that class is instantiated per compiled query, then it implies calls to StagePlanner should be thread safe ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
