richardstartin commented on a change in pull request #8364:
URL: https://github.com/apache/pinot/pull/8364#discussion_r829540624
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/Fixtures.java
##########
@@ -67,8 +65,8 @@ private Fixtures() {
+ " \"stream.fakeStream.broker.list\":\"broker:7777\","
+ "
\"stream.fakeStream.consumer.prop.auto.offset.reset\":\"smallest\","
+ " \"stream.fakeStream.consumer.type\":\"simple\","
- + " \"stream.fakeStream.consumer.factory.class.name\":\"" +
CONSUMER_FACTORY_CLASS + "\","
- + " \"stream.fakeStream.decoder.class.name\":\"" +
MESSAGE_DECODER_CLASS + "\","
+ + " \"stream.fakeStream.consumer.factory.class.name\":\"" +
CONSUMER_FACTORY_CLASS_FORMATTER + "\","
+ + " \"stream.fakeStream.decoder.class.name\":\"" +
MESSAGE_DECODER_CLASS_FORMATTER + "\","
Review comment:
Just embed the "%s" directly here?
```java
public static final String CONSUMER_FACTORY_CLASS_FORMATTER = "%s";
public static final String MESSAGE_DECODER_CLASS_FORMATTER = "%s";
```
looks weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
