weixiangsun commented on a change in pull request #8029:
URL: https://github.com/apache/pinot/pull/8029#discussion_r829468126
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java
##########
@@ -375,6 +393,57 @@ public String toString() {
private Map<String, String> _queryOptions;
private Map<String, String> _debugOptions;
private BrokerRequest _brokerRequest;
+ private QueryContext _subQueryContext;
+
+ /**
+ * Helper method to extract AGGREGATION FunctionContexts and FILTER
FilterContexts from the given expression.
+ */
+ private static void getAggregations(ExpressionContext expression,
+ List<Pair<FunctionContext, FilterContext>> filteredAggregations) {
+ FunctionContext function = expression.getFunction();
+ if (function == null) {
+ return;
+ }
+ if (function.getType() == FunctionContext.Type.AGGREGATION) {
+ // Aggregation
+ filteredAggregations.add(Pair.of(function, null));
+ } else {
+ List<ExpressionContext> arguments = function.getArguments();
+ if (function.getFunctionName().equalsIgnoreCase("filter")) {
+ // Filtered aggregation
+ Preconditions.checkState(arguments.size() == 2, "FILTER must contain
2 arguments");
+ FunctionContext aggregation = arguments.get(0).getFunction();
+ Preconditions.checkState(aggregation != null &&
aggregation.getType() == FunctionContext.Type.AGGREGATION,
+ "First argument of FILTER must be an aggregation function");
+ ExpressionContext filterExpression = arguments.get(1);
+ Preconditions.checkState(filterExpression.getFunction() != null
+ && filterExpression.getFunction().getType() ==
FunctionContext.Type.TRANSFORM,
+ "Second argument of FILTER must be a filter expression");
+ FilterContext filter =
RequestContextUtils.getFilter(filterExpression);
+ filteredAggregations.add(Pair.of(aggregation, filter));
+ } else {
+ // Transform
+ for (ExpressionContext argument : arguments) {
+ getAggregations(argument, filteredAggregations);
+ }
+ }
+ }
+ }
+
+ /**
+ * Helper method to extract AGGREGATION FunctionContexts and FILTER
FilterContexts from the given filter.
+ */
+ private static void getAggregations(FilterContext filter,
+ List<Pair<FunctionContext, FilterContext>> filteredAggregations) {
+ List<FilterContext> children = filter.getChildren();
+ if (children != null) {
+ for (FilterContext child : children) {
+ getAggregations(child, filteredAggregations);
+ }
+ } else {
+ getAggregations(filter.getPredicate().getLhs(), filteredAggregations);
+ }
+ }
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
