richardstartin commented on a change in pull request #8364:
URL: https://github.com/apache/pinot/pull/8364#discussion_r829480673
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java
##########
@@ -212,40 +209,23 @@ public void build()
_recordReader.rewind();
LOGGER.info("Start building IndexCreator!");
GenericRow reuse = new GenericRow();
+ TransformPipeline.Result reusedResult = new TransformPipeline.Result();
while (_recordReader.hasNext()) {
long recordReadStartTime = System.currentTimeMillis();
long recordReadStopTime;
long indexStopTime;
reuse.clear();
GenericRow decodedRow = _recordReader.next(reuse);
- if (_complexTypeTransformer != null) {
- // TODO: consolidate complex type transformer into composite type
transformer
- decodedRow = _complexTypeTransformer.transform(decodedRow);
- }
- if (decodedRow.getValue(GenericRow.MULTIPLE_RECORDS_KEY) != null) {
- recordReadStopTime = System.currentTimeMillis();
- _totalRecordReadTime += (recordReadStopTime - recordReadStartTime);
- for (Object singleRow : (Collection)
decodedRow.getValue(GenericRow.MULTIPLE_RECORDS_KEY)) {
- recordReadStartTime = System.currentTimeMillis();
- GenericRow transformedRow =
_recordTransformer.transform((GenericRow) singleRow);
- recordReadStopTime = System.currentTimeMillis();
- _totalRecordReadTime += (recordReadStopTime - recordReadStartTime);
- if (transformedRow != null &&
IngestionUtils.shouldIngestRow(transformedRow)) {
- _indexCreator.indexRow(transformedRow);
- indexStopTime = System.currentTimeMillis();
- _totalIndexTime += (indexStopTime - recordReadStopTime);
- }
- }
- } else {
- GenericRow transformedRow = _recordTransformer.transform(decodedRow);
- recordReadStopTime = System.currentTimeMillis();
- _totalRecordReadTime += (recordReadStopTime - recordReadStartTime);
- if (transformedRow != null &&
IngestionUtils.shouldIngestRow(transformedRow)) {
- _indexCreator.indexRow(transformedRow);
- indexStopTime = System.currentTimeMillis();
- _totalIndexTime += (indexStopTime - recordReadStopTime);
- }
+ recordReadStartTime = System.currentTimeMillis();
+ _transformPipeline.processRow(decodedRow, reusedResult);
Review comment:
👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
