kkrugler commented on a change in pull request #8329:
URL: https://github.com/apache/pinot/pull/8329#discussion_r829506216
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java
##########
@@ -232,8 +235,7 @@ public static void installDefaultSSLSocketFactory(String
keyStoreType, String ke
Protocol.registerProtocol("https",
new Protocol(CommonConstants.HTTPS_PROTOCOL, new
PinotProtocolSocketFactory(sc.getSocketFactory()), 443));
- // FileUploadDownloadClient
- FileUploadDownloadClient.installDefaultSSLContext(sc);
+ _sslContext = sc;
Review comment:
I think this should call `setSslContext()`, and that method should be
synchronized, or use an `AtomicReference< SSLContext>`, to avoid potential
concurrency issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
