walterddr commented on a change in pull request #8329:
URL: https://github.com/apache/pinot/pull/8329#discussion_r829305394
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java
##########
@@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String storePath)
return inputUri.toURL();
}
+ public static SSLContext getSslContext() {
+ return _sslContext != null ? _sslContext : SSLContexts.createDefault();
Review comment:
yeah I was thinking about using lazy static initialization similar to
https://stackoverflow.com/a/7420714 since it is static thread safe.
However the current way how TLSUtils install the TLSSpec is non-static. so
it might not be possible to acquire the TLSSpecs at jvm start up time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
