[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

amrishlal commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620895934 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -345,6 +346,15 @@ public Br

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

amrishlal commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620895878 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -428,6 +438,25 @@ public Br

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

amrishlal commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620895878 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -428,6 +438,25 @@ public Br

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

amrishlal commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620895795 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -151,7 +157,10 @@ public static Expressi

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

amrishlal commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620895691 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/QueryOptimizer.java ## @@ -31,12 +31,14 @@ import org.apache.pin

[GitHub] [incubator-pinot] troywinter commented on issue #6848: Support fill null value with default value when column is not present in record

troywinter commented on issue #6848: URL: https://github.com/apache/incubator-pinot/issues/6848#issuecomment-827332169 > Pinot should be able to fill the default value. Not sure what has caused the exception. > Can you please share the table config and schema? Have you configured any r

[GitHub] [incubator-pinot] kishoreg commented on pull request #6845: Add the complex data type transformer for complex type handling

kishoreg commented on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827325511 this is awesome lets ask some users to provide feedback on the spec? complexTypeHandlingConfig: { "mode": "FLATTEN_MAP",

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6846: Fix issue - no authentication is required for GET table endpoint

codecov-commenter edited a comment on pull request #6846: URL: https://github.com/apache/incubator-pinot/pull/6846#issuecomment-827262837 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot-site] branch dev updated (73fcb86 -> 31ec328)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git. discard 73fcb86 adding github action to publish asf-site new 31ec328 adding github action to publish asf-s

[incubator-pinot-site] 01/01: adding github action to publish asf-site

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git commit 31ec3289523c931df468b1ba7fa10e4e7ad6012a Author: Xiang Fu AuthorDate: Fri Apr 23 16:30:57 2021 -0700 ad

[incubator-pinot-site] branch asf-site updated (c205ade -> 8efd188)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git. discard c205ade Remove website src and update readme new 8efd188 Remove website src and update readme

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6848: Support fill null value with default value when column is not present in record

Jackie-Jiang commented on issue #6848: URL: https://github.com/apache/incubator-pinot/issues/6848#issuecomment-827307005 Pinot should be able to fill the default value. Not sure what has caused the exception. Can you please share the table config and schema? Have you configured any rec

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6845: Add the complex data type transformer for complex type handling

codecov-commenter edited a comment on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827242858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6845: Add the complex data type transformer for complex type handling

codecov-commenter edited a comment on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827242858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] troywinter opened a new issue #6848: Support fill null value with default value when column is not present in record

troywinter opened a new issue #6848: URL: https://github.com/apache/incubator-pinot/issues/6848 We are getting `Caught exception while transforming the record:` when ingesting json data from kafka, it will throw `java.lang.ClassCastException: null` and no stack trace will be printed. The p

[incubator-pinot] branch master updated: Add absolute path support for compatibility testing(#6787) (#6828)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b4d75a3 Add absolute path support fo

[GitHub] [incubator-pinot] mcvsubbu merged pull request #6828: Add absolute path support for compatibility testing(#6787)

mcvsubbu merged pull request #6828: URL: https://github.com/apache/incubator-pinot/pull/6828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6847: Change ConcatCollector implementation to use off-heap

codecov-commenter commented on pull request #6847: URL: https://github.com/apache/incubator-pinot/pull/6847#issuecomment-827270364 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6847?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6844: Support the duplicate selection of the query

Jackie-Jiang commented on issue #6844: URL: https://github.com/apache/incubator-pinot/issues/6844#issuecomment-827269859 Does standard SQL support making 2 different alias on the same column? To support selecting duplicate columns, you can change `SelectionDataTableReducer` and pass `se

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang merged pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

Jackie-Jiang commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r620796986 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6846: Fix issue - no authentication is required for GET table endpoint

codecov-commenter commented on pull request #6846: URL: https://github.com/apache/incubator-pinot/pull/6846#issuecomment-827262837 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

Jackie-Jiang commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620794795 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

Jackie-Jiang commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620787772 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [incubator-pinot] npawar opened a new pull request #6847: Change ConcatCollector implementation to use off-heap

npawar opened a new pull request #6847: URL: https://github.com/apache/incubator-pinot/pull/6847 See https://github.com/apache/incubator-pinot/issues/6770 for motivation Pending: This PR only changes ConcatCollector. Will update RollupCollector in a following PR. -- This is an aut

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6719: Add TIMESTAMP and BOOLEAN data type support

codecov-commenter edited a comment on pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#issuecomment-827242765 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6719?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6845: Add the complex data type transformer for complex type handling

codecov-commenter commented on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827242858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6719: Add TIMESTAMP and BOOLEAN data type support

codecov-commenter commented on pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#issuecomment-827242765 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6719?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6840: TableConfigs APIs

Jackie-Jiang commented on a change in pull request #6840: URL: https://github.com/apache/incubator-pinot/pull/6840#discussion_r620748224 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/TableConfigs.java ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Softw

[GitHub] [incubator-pinot] desaijay230592 closed pull request #6818: Azure Environment Provider to retrieve Failure Domain Info from Insta…

desaijay230592 closed pull request #6818: URL: https://github.com/apache/incubator-pinot/pull/6818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6846: Fix issue - no authentication is required for GET table endpoint

sajjad-moradi opened a new pull request #6846: URL: https://github.com/apache/incubator-pinot/pull/6846 ## Description `/tables/{tableName}` endpoint on Table Resource is mistakenly annotated with @Authenticat(UPDATE), while this endpoint can be used only to get the table config. This P

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r620753371 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -20,9 +20,10 @@ import java.io.File;

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620746269 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -315,6 +408,58 @@ public Double convert(Obje

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620745676 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -228,6 +229,22 @@ public stati

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620745364 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -228,6 +229,22 @@ public stati

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620744508 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apac

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620743637 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apac

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620744131 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apac

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620743637 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apac

[incubator-pinot] branch master updated (ac5aee7 -> 0dcdc5b)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ac5aee7 Update ApachePinot image version and update zK in helm (#6838) add 0dcdc5b Use ServerTime

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6830: Use ServerTimer instead of Gauge for emitting cpu time metric

siddharthteotia merged pull request #6830: URL: https://github.com/apache/incubator-pinot/pull/6830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #6828: Add absolute path support for compatibility testing(#6787)

GSharayu commented on a change in pull request #6828: URL: https://github.com/apache/incubator-pinot/pull/6828#discussion_r620741894 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/CompatibilityOpsRunner.java ## @@ -35,15 +38,17 @@ private Com

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6828: Add absolute path support for compatibility testing(#6787)

mqliang commented on a change in pull request #6828: URL: https://github.com/apache/incubator-pinot/pull/6828#discussion_r620734507 ## File path: compatibility-verifier/sample-test-suite/sample.yaml ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6828: Add absolute path support for compatibility testing(#6787)

mcvsubbu commented on a change in pull request #6828: URL: https://github.com/apache/incubator-pinot/pull/6828#discussion_r620728373 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/CompatibilityOpsRunner.java ## @@ -35,15 +38,17 @@ private Com

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6845: Add the complex data type transformer for complex type handling

yupeng9 opened a new pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845 Part 1 for the complex type handling. Design doc: https://docs.google.com/document/d/1L6d0k_yF4TbFWHt5IJ5eYYjJZboRnJTBrQYRB2an9iI/edit# ## Description Add the transformer to transform

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r620730001 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ## @@ -321,6 +323,10 @@ public void

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6361: Detect invalid column names from query in Pinot server

jackjlli commented on a change in pull request #6361: URL: https://github.com/apache/incubator-pinot/pull/6361#discussion_r620729664 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -208,6 +209,11 @@ public BrokerResponse

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620728733 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620727747 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/BooleanQueriesTest.java ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

Jackie-Jiang commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620727402 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -352,13 +368,41 @@ public int hashCode() { public enu

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

codecov-commenter edited a comment on pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#issuecomment-821935835 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6811?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6361: Detect invalid column names from query in Pinot server

mqliang commented on a change in pull request #6361: URL: https://github.com/apache/incubator-pinot/pull/6361#discussion_r620722571 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -208,6 +209,11 @@ public BrokerResponseN

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6361: Detect invalid column names from query in Pinot server

jackjlli commented on a change in pull request #6361: URL: https://github.com/apache/incubator-pinot/pull/6361#discussion_r620719548 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java ## @@ -303,6 +299,31 @@ private DataT

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6361: Detect invalid column names from query in Pinot server

mqliang commented on a change in pull request #6361: URL: https://github.com/apache/incubator-pinot/pull/6361#discussion_r620714911 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java ## @@ -303,6 +299,31 @@ private DataTa

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6841: Refactor gcs

codecov-commenter edited a comment on pull request #6841: URL: https://github.com/apache/incubator-pinot/pull/6841#issuecomment-826386376 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6843: Allow BYTES/Struct and complex type fields to exceed default max length

siddharthteotia commented on a change in pull request #6843: URL: https://github.com/apache/incubator-pinot/pull/6843#discussion_r620716882 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -381,10 +381,10 @@ public int size() { /**

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6841: Refactor gcs

jackjlli commented on a change in pull request #6841: URL: https://github.com/apache/incubator-pinot/pull/6841#discussion_r620713631 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java ## @@ -108,7 +108,16 @@ public boolean move(URI srcUri, URI ds

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6841: Refactor gcs

xiangfu0 commented on a change in pull request #6841: URL: https://github.com/apache/incubator-pinot/pull/6841#discussion_r620703094 ## File path: pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java ## @@ -34,104 +35,211 @

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6841: Refactor gcs

xiangfu0 commented on a change in pull request #6841: URL: https://github.com/apache/incubator-pinot/pull/6841#discussion_r620703094 ## File path: pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java ## @@ -34,104 +35,211 @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620672041 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the A

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620672041 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the A

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6841: Refactor gcs

codecov-commenter edited a comment on pull request #6841: URL: https://github.com/apache/incubator-pinot/pull/6841#issuecomment-826386376 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620659388 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -228,6 +229,22 @@ public st

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620657416 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -228,6 +229,22 @@ public st

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620655228 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -228,6 +229,22 @@ public st

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620655228 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -228,6 +229,22 @@ public st

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620648078 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the A

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620647615 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the A

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620644657 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TimestampQueriesTest.java ## @@ -0,0 +1,229 @@ +/** + * Licensed to the A

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6820: Add ago() scalar transform function

jackjlli commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r620635368 ## File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java ## @@ -1713,6 +1713,24 @@ public void testComp

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620638226 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java ## @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620631641 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/BooleanQueriesTest.java ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apa

[GitHub] [incubator-pinot] xiangfu0 commented on pull request #6830: Use ServerTimer instead of Gauge for emitting cpu time metric

xiangfu0 commented on pull request #6830: URL: https://github.com/apache/incubator-pinot/pull/6830#issuecomment-827132130 please format your code to pass ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620631641 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/BooleanQueriesTest.java ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apa

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6719: Add TIMESTAMP and BOOLEAN data type support

siddharthteotia commented on a change in pull request #6719: URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620627441 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -352,13 +368,41 @@ public int hashCode() { public

[GitHub] [incubator-pinot] snleee opened a new issue #6844: Support the duplicate selection of the query

snleee opened a new issue #6844: URL: https://github.com/apache/incubator-pinot/issues/6844 Currently, Pinot does the deduplication for selection on the same column while the standard SQL doesn't perform the deduplication. ``` select colA as xx, colA as yy from T --> t

[GitHub] [incubator-pinot] rkanumul commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

rkanumul commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r620585103 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ## @@ -321,6 +323,10 @@ public void start

[GitHub] [incubator-pinot] rkanumul commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

rkanumul commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r620583918 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ## @@ -321,6 +323,10 @@ public void start

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6843: Allow BYTES/Struct and complex type fields to exceed default max length

codecov-commenter commented on pull request #6843: URL: https://github.com/apache/incubator-pinot/pull/6843#issuecomment-827082684 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

codecov-commenter edited a comment on pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#issuecomment-821935835 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6811?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] chenboat opened a new pull request #6843: Allow BYTES/Struct and complex type fields to exceed default max length

chenboat opened a new pull request #6843: URL: https://github.com/apache/incubator-pinot/pull/6843 Allow BYTES/Struct and complex type fields to exceed default max length of 500 bytes. ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume up

[GitHub] [incubator-pinot] desaijay230592 commented on issue #6532: Server Rack Metadata Retrieval and Persistence on Azure Environment

desaijay230592 commented on issue #6532: URL: https://github.com/apache/incubator-pinot/issues/6532#issuecomment-827052752 Please refer to the PR #6842 for Failure Domain Retrieval Logic for Server Instances. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-pinot] desaijay230592 opened a new pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 opened a new pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842 … Domain Information for the Server Instance ## Description Creating generic interface PinotEnvironment which can be implemented by various cloud providers to customize the Pin

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

Jackie-Jiang commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r620520759 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214

[GitHub] [incubator-pinot] mqliang edited a comment on pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

mqliang edited a comment on pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#issuecomment-827016380 LGTM. I have a generic question which is not related to this PR. I observe there are bunch of pre-processing logic for a request: * authz/authn * adm

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6828: Add absolute path support for compatibility testing(#6787)

codecov-commenter edited a comment on pull request #6828: URL: https://github.com/apache/incubator-pinot/pull/6828#issuecomment-824222900 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mqliang commented on pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

mqliang commented on pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#issuecomment-827016380 I have a generic question which is not related to this PR. I observe there are bunch of pre-processing logic for a request: * authz/authn * admission control (e.g.

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6840: TableConfigs APIs

jackjlli commented on a change in pull request #6840: URL: https://github.com/apache/incubator-pinot/pull/6840#discussion_r620490715 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java ## @@ -165,9 +146,13 @@ pu

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6828: Add absolute path support for compatibility testing(#6787)

codecov-commenter edited a comment on pull request #6828: URL: https://github.com/apache/incubator-pinot/pull/6828#issuecomment-824222900 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6811: Normalize LHS and RHS numerical types for = and != operator.

amrishlal commented on a change in pull request #6811: URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r619889565 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/QueryOptimizer.java ## @@ -31,12 +31,14 @@ import org.apache.pin

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6840: Configs APIs

codecov-commenter commented on pull request #6840: URL: https://github.com/apache/incubator-pinot/pull/6840#issuecomment-826221712 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6840: Configs APIs

npawar commented on a change in pull request #6840: URL: https://github.com/apache/incubator-pinot/pull/6840#discussion_r619921969 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/PinotConfig.java ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6839: Update helm chart - Include securityContext, gracePeriod and remove duplicates in helm

codecov-commenter commented on pull request #6839: URL: https://github.com/apache/incubator-pinot/pull/6839#issuecomment-826151078 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6841: Refactor gcs

codecov-commenter commented on pull request #6841: URL: https://github.com/apache/incubator-pinot/pull/6841#issuecomment-826386376 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen