desaijay230592 opened a new pull request #6842:
URL: https://github.com/apache/incubator-pinot/pull/6842


   … Domain Information for the Server Instance
   
   ## Description
   Creating generic interface PinotEnvironment which can be implemented by 
various cloud providers to customize the PinotConfiguration by setting 
different environment variables and other instance specific configuration.
   
   Primary aim is to update the server instance config with failure/fault 
domain information which will be useful when designing segment assignment 
strategy to achieve high availability.
   
   This change introduces a PinotEnvironment interface under pinot-spi(a.ka 
pinot-service-provider-interface). We introduce a pinot-enviroment/pinot-azure 
plugin containing AzureEnvironmentProvider class to provide azure specific 
pinot configuration customization which contains failure domain information. 
This failure domain information is retrieved from Azure IMDS (Instance Metadata 
Service) wherein call has to be made from within the VM.
   
   Unit Tests are written for the same. End-End integration tests are 
in-progress. Will take LinkedIN Pinot-SRE help to conduct those.
   
   Design Document: 
https://docs.google.com/document/d/1echXSSZfgKWLtkmA1KKxmdCRUkTqffqoJhNA-ovTfzc/
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: 
Controller, Broker, Server, Minion)
   * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete 
the section below on Release Notes)
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and 
complete the section below on Release Notes)
   
   Does this PR otherwise need attention when creating release notes? Things to 
consider:
   - New configuration options
   - New plugins added or old plugins removed
   * [ ] Yes (Please label this PR as **<code>release-notes</code>** and 
complete the section on Release Notes)
   ## Release Notes
   <!-- If you have tagged this as either backward-incompat or release-notes,
   you MUST add text here that you would like to see appear in release notes of 
the
   next release. -->
   
   <!-- If you have a series of commits adding or enabling a feature, then
   add this section only in final commit that marks the feature completed.
   Refer to earlier release notes to see examples of text.
   -->
   ## Documentation
   <!-- If you have introduced a new feature or configuration, please add it to 
the documentation as well.
   See 
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to