amrishlal commented on a change in pull request #6811:
URL: https://github.com/apache/incubator-pinot/pull/6811#discussion_r620895934
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -345,6 +346,15 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
requestStatistics.setFanoutType(RequestStatistics.FanoutType.REALTIME);
}
+ // Check if response can be send without server query evaluation.
+ if (isResponsePossible(offlineBrokerRequest) &&
isResponsePossible(realtimeBrokerRequest)) {
Review comment:
Renamed to `isFilterAlwaysFalse` and also added `isFilterAlwaysTrue` to
take care of all cases including setting `offlineBrokerRequest` or
`realtimeBrokerRequest` to null if needed and dropping filter if filter will
always evaluate to TRUE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
