rkanumul commented on a change in pull request #6842:
URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r620583918
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -321,6 +323,10 @@ public void start()
LOGGER.info("Initializing server instance and registering state model
factory");
Utils.logVersions();
ControllerLeaderLocator.create(_helixManager);
+
+ // Invoke Pinot Environment Provider's Init method to register the
environment provider
+
PinotEnvironmentProviderFactory.init(_serverConf.subset(PREFIX_OF_CONFIG_OF_ENVIRONMENT_PROVIDER_FACTORY));
Review comment:
This inits the provider. can we also do getEnvironment to override the
configs ?
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -20,9 +20,10 @@
import java.io.File;
-
public class CommonConstants {
+ public static final String PLATFORM_FAULT_DOMAIN = "platformFaultDomain";
Review comment:
This constant can be in AzureEnvironmentProvider
given it is a constant tightly related to azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
