mqliang commented on a change in pull request #6361:
URL: https://github.com/apache/incubator-pinot/pull/6361#discussion_r620722571
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##########
@@ -208,6 +209,11 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
numGroupsLimitReached |=
Boolean.parseBoolean(metadata.get(MetadataKey.NUM_GROUPS_LIMIT_REACHED.getName()));
+ String invalidColumnNamesString =
metadata.get(MetadataKey.INVALID_COLUMN_IN_QUERY.getName());
+ if (invalidColumnNamesString != null) {
+ invalidColumnNames = invalidColumnNames == null ?
invalidColumnNamesString : invalidColumnNames;
+ }
Review comment:
Can be changed as:
```
if (invalidColumnNames != null && invalidColumnNamesString != null) {
invalidColumnNames = invalidColumnNamesString;
}
```
Which is a little bit more succinct. This is a minor comments, up to you to
change or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
