siddharthteotia commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r620659388
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -228,6 +229,22 @@ public static long fromEpochDaysBucket(long days, long
bucket) {
return TimeUnit.DAYS.toMillis(days * bucket);
}
+ /**
Review comment:
There are existing functions in this class like dayOfWeek, dayOfYear
etc. I think we should add a version of those on Timestamp type. Alternately,
since the stored type is long, may be they will automatically work on column of
TIMESTAMP type ?
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -228,6 +229,22 @@ public static long fromEpochDaysBucket(long days, long
bucket) {
return TimeUnit.DAYS.toMillis(days * bucket);
}
+ /**
Review comment:
There are existing functions in this class like dayOfWeek, dayOfYear
etc. I think we should add a version of those on TIMESTAMP type. Alternately,
since the stored type is long, may be they will automatically work on column of
TIMESTAMP type ?
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -228,6 +229,22 @@ public static long fromEpochDaysBucket(long days, long
bucket) {
return TimeUnit.DAYS.toMillis(days * bucket);
}
+ /**
Review comment:
There are existing functions in this class like dayOfWeek, dayOfYear
etc. I think we should add a version of those on `TIMESTAMP` type. Alternately,
since the stored type is long, may be they will automatically work on column of
`TIMESTAMP` type ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
