[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3896 +// encoder. Prefixes |= X86::IP_USE_VEX3; +Prefixes |= X86::Force_VEX3Encoding; craig.topper wrote: > LiuChen3 wrote: > > craig.topper wrote: > > > Why d

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3896 +// encoder. Prefixes |= X86::IP_USE_VEX3; +Prefixes |= X86::Force_VEX3Encoding; LiuChen3 wrote: > craig.topper wrote: > > Why do we need Force_VEX3En

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/att-inline-asm-prefix.c:14 +"{vex2} vcvtps2pd %xmm0, %xmm1\n\t" +"{vex3} vcvtps2pd %xmm0, %xmm1\n\t" +"{evex} vcvtps2pd %xmm0, %xmm1\n\t" > Does this bug only effect the printing of in

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

craig.topper added a comment. Does this bug only effect the printing of inline assembly to a .s file? The encoder should work correctly even without this I think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90009/new/ https://reviews.llvm.org/D9

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp:358 + else if (Flags & X86::Force_EVEXEncoding) +O << "\t{evex}"; } We also need to print {disp8} and {disp32} here to fix the same bug with those rig

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/SourceManager.h:118 + private: +unsigned *Storage = nullptr; + }; I guess it's implicit in the im

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89554/new/ https://reviews.llvm.org/D89554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp:354 + else if (Flags & X86::Force_VEX2Encoding) +O << "\t{vex2}"; + else if (Flags & X86::Force_VEX3Encoding) craig.topper wrote: > Is it important tha

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

JDevlieghere added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:293 X.ContentAndKind.setInt(FileCharacter); - X.Filename = Filename; + const_cast(Con).Filename = Filename; return X; Would it possibly make more sen

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM if Shafik is happy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89554/new/ https://reviews.llvm.org/D89554 ___ cfe-commi

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3896 +// encoder. Prefixes |= X86::IP_USE_VEX3; +Prefixes |= X86::Force_VEX3Encoding; Why do we need Force_VEX3Encoding and IP_USE_VEX3?

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2824 ForcedVEXEncoding = VEXEncoding_VEX; + else if (Prefix == "vex2") +ForcedVEXEncoding = VEXEncoding_VEX2; pengfei wrote: > I think it's reasonable

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo created this revision. Hiralo added reviewers: alexfh, njames93, hokein, DmitryPolukhin, djasper, ilya-biryukov. Hiralo added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hiralo requested review of this revision. commit c3fa7da502d6cc

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2824 ForcedVEXEncoding = VEXEncoding_VEX; + else if (Prefix == "vex2") +ForcedVEXEncoding = VEXEncoding_VEX2; I think it's reasonable if we generate "{

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/att-inline-asm-prefix.c:12 +// CHECK: {evex} vcvtps2pd %xmm0, %xmm1 +"{vex} vcvtps2pd %xmm0, %xmm1\n\t" +"{vex2} vcvtps2pd %xmm0, %xmm1\n\t" Better adding a no prefix one. ===

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. LiuChen3 requested review of this revision. For now, we lost the encoding information if we using inline assembly. The encoding for the inline assembly will keep defa

[PATCH] D90007: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

tstellar created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. tstellar requested review of this revision. Fix premature decision in the presence of type-dependent expression operands on whether AltiVec vector initializations from single expressions are "spl

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

OikawaKirie added a comment. Since `SymbolRef` is just a `const SymExpr *` in the current codebase, I'd prefer using `const SymExpr *` directly, just like how `MemRegion` is used, which would be clearer than both `SymbolRef` and `SymExprRef` as far as I am thinking. Different from `ProgramStat

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith added inline comments. Comment at: clang/test/Parser/pragma-fenv_access.c:28 +#if defined(CPP) & defined(STRICT) +//not-expected-error@+3 {{constexpr variable 'frac' must be initialized by a constant expression}} +//not-expected-note@+2 {{compile time floating point arith

[clang] 3b8d895 - SourceManager: Remove a redundant nullptr check in getNonBuiltinFilenameForID, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-22T22:20:50-04:00 New Revision: 3b8d8954bf2c192502d757019b9fe434864068e9 URL: https://github.com/llvm/llvm-project/commit/3b8d8954bf2c192502d757019b9fe434864068e9 DIFF: https://github.com/llvm/llvm-project/commit/3b8d8954bf2c192502d757019b9fe4348640

[PATCH] D89508: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf593d224c9c: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] cf593d2 - SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-22T22:20:50-04:00 New Revision: cf593d224c9c3fc2cf93827cb66fd9e550a6a486 URL: https://github.com/llvm/llvm-project/commit/cf593d224c9c3fc2cf93827cb66fd9e550a6a486 DIFF: https://github.com/llvm/llvm-project/commit/cf593d224c9c3fc2cf93827cb66fd9e550a6

[PATCH] D89507: SourceManager: Change SourceManager::isMainFile to take a FileEntry, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG168db92465c5: SourceManager: Change SourceManager::isMainFile to take a FileEntry, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 168db92 - SourceManager: Change SourceManager::isMainFile to take a FileEntry, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-22T21:32:28-04:00 New Revision: 168db92465c504974274302a6a1a5d4a1580ccfe URL: https://github.com/llvm/llvm-project/commit/168db92465c504974274302a6a1a5d4a1580ccfe DIFF: https://github.com/llvm/llvm-project/commit/168db92465c504974274302a6a1a5d4a1580

[clang] b6c6daa - SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-22T21:30:31-04:00 New Revision: b6c6daa95d3aa2206d5a42b46793226f181c3e44 URL: https://github.com/llvm/llvm-project/commit/b6c6daa95d3aa2206d5a42b46793226f181c3e44 DIFF: https://github.com/llvm/llvm-project/commit/b6c6daa95d3aa2206d5a42b46793226f181c

[PATCH] D89503: SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c6daa95d3a: SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling support for non-type template parameters of class type and template parameter objects.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. rsmith requested review of this revision. This follows the approach I proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/47 on 2020-09-06. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

rsmith added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT:stw 0, 8(1) +// COMMON-ASM-NEXT:stwu 1, -64(1) +// COMMON-ASM-NEXT:bl ._Z1fv +// NOP-ASM-NEXT: nop ---

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:4794 CGM.getModule(), LLVMStaticTy, - /*isConstant=*/false, llvm::GlobalValue::CommonLinkage, - llvm::Constant::getNullValue(LLVMStaticTy), + /*isCons

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

JonChesterfield added a comment. In D89994#2348656 , @ABataev wrote: > In D89994#2348655 , @JonChesterfield > wrote: > >> The nvptx back end accepts common + zero + shared, but not common + undef + >> shared. I th

[clang] af189c8 - Fix constant evaluation of zero-initialization of a union whose first

Author: Richard Smith Date: 2020-10-22T17:03:59-07:00 New Revision: af189c8ab113668434eae5c71f174613a9e64625 URL: https://github.com/llvm/llvm-project/commit/af189c8ab113668434eae5c71f174613a9e64625 DIFF: https://github.com/llvm/llvm-project/commit/af189c8ab113668434eae5c71f174613a9e64625.diff

[PATCH] D89882: [clangd] Offset enum values by when marshalling

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Index.proto:15 // structures corresponding to their clangd::* counterparts. +// NOTE: Enum values are offset by one to detect missing values. service SymbolIndex { can we just sw

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added a comment. As a follow up, I probably want to make `-fno-stack-protector` sprinkle this new fn attr `nossp` all over everything; that and this should fix our LTO bug with no changes to the source, otherwise we can add `__attribute__((no_stack_protector))` to the source (th

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added a comment. In D87956#2348446 , @void wrote: > Why not just use "expected-error" and the like? Ah, brilliant! Thank you! Will wait to submit until tomorrow morning. Comment at: llvm/docs/BitCodeFormat.rst:1072 +*

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers updated this revision to Diff 300124. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase, add alwaysinline tests, use expected-remark, improve remarks Repository: rG LLVM Github Monorepo

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good with a test for explicit zero initialization. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3157 + +if (Value.isNullValue()) + continue; ---

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added a comment. In D89994#2348655 , @JonChesterfield wrote: > The nvptx back end accepts common + zero + shared, but not common + undef + > shared. I think weak_odr is conceptually right here, but given the warning > that nvlink doesn't support

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

JonChesterfield added a comment. The nvptx back end accepts common + zero + shared, but not common + undef + shared. I think weak_odr is conceptually right here, but given the warning that nvlink doesn't support weak symbols, internal also seems fine. Can someone see an advantage to weak over i

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, ABataev, grokos, tianshilei1992, ye-luo. Herald added a project: clang. Herald added a subscriber: cfe-commits. JonChesterfield requested review of this revision. [libomptarget][nvptx] Undef, internal shared variab

[PATCH] D83088: Introduce CfgTraits abstraction

mehdi_amini added a comment. In D83088#2347111 , @arsenm wrote: > In D83088#2346322 , @mehdi_amini > wrote: > >> In D83088#2345540 , @nhaehnle wrote: >> >>> David, I don't t

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:20 +// RUN: FileCheck -check-prefixes=COMMON-IR,VISIBILITY-IR %s + +int x = 66; There's no testing for the interaction with `-mignore-xcoff-visibility`.

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rnk added a comment. Herald added a subscriber: dexonsmith. Thanks, I like the new direction, hopefully others agree. Sorry for providing slow feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews.llvm.org/D89910 ___

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

alexfh accepted this revision. alexfh added a comment. In D89886#2347376 , @DmitryPolukhin wrote: > In D89886#2346851 , @alexfh wrote: > >> Ah, btw, any chance of adding a test for this? > > Oh, I was not able to c

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall updated this revision to Diff 300107. sammccall added a comment. Fix nullptr condition (probably dead, but...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89743/new/ https://reviews.llvm.org/D89743 Files: clang/docs/LibASTMatchersRef

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall updated this revision to Diff 300106. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments. Add hasAttrName() and make isImplicit() support Attr too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall added a comment. In D89743#2342229 , @aaron.ballman wrote: > In D89743#2341900 , @sammccall wrote: > >> In D89743#2341779 , @aaron.ballman >> wrote: >> >>> This i

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/test/Parser/pragma-fenv_access.c:28 +#if defined(CPP) & defined(STRICT) +//not-expected-error@+3 {{constexpr variable 'frac' must be initialized by a constant expression}} +//not-expected-note@+2 {{compile time floating point arit

[PATCH] D89961: [libTooling] Add function to Transformer to create a no-op edit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f8f5cb77efd: [libTooling] Add function to Transformer to create a no-op edit. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6f8f5cb - [libTooling] Add function to Transformer to create a no-op edit.

Author: Yitzhak Mandelbaum Date: 2020-10-22T21:29:03Z New Revision: 6f8f5cb77efd100e5d4916db871b18c88cf49ed0 URL: https://github.com/llvm/llvm-project/commit/6f8f5cb77efd100e5d4916db871b18c88cf49ed0 DIFF: https://github.com/llvm/llvm-project/commit/6f8f5cb77efd100e5d4916db871b18c88cf49ed0.diff

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

DiggerLin created this revision. DiggerLin added reviewers: jasonliu, hubert.reinterpretcast, sfertile. Herald added a project: clang. Herald added a subscriber: cfe-commits. DiggerLin requested review of this revision. in AIX OS, we will ignore the option -fvisibility-inlines-hidden when there is

[clang] 8277a51 - [SourceManager] Avoid copying SLocEntry in computeMacroArgsCache

Author: Jan Korous Date: 2020-10-22T14:18:28-07:00 New Revision: 8277a513c74b53e5ad7f482f76b27bc8609c66ae URL: https://github.com/llvm/llvm-project/commit/8277a513c74b53e5ad7f482f76b27bc8609c66ae DIFF: https://github.com/llvm/llvm-project/commit/8277a513c74b53e5ad7f482f76b27bc8609c66ae.diff LO

[clang] fd14a1f - [clang][Frontend] Add missing error handling

Author: LemonBoy Date: 2020-10-22T14:14:19-07:00 New Revision: fd14a1f6fff37ef62a35ca0f8bc630ac8b23516d URL: https://github.com/llvm/llvm-project/commit/fd14a1f6fff37ef62a35ca0f8bc630ac8b23516d DIFF: https://github.com/llvm/llvm-project/commit/fd14a1f6fff37ef62a35ca0f8bc630ac8b23516d.diff LOG:

[PATCH] D78658: [clang][Frontend] Add missing error handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd14a1f6fff3: [clang][Frontend] Add missing error handling (authored by LemonBoy, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

void added a comment. In D87956#2348433 , @nickdesaulniers wrote: > In phab here, it looks like my newly added > clang/test/Frontend/optimization-remark-missed-inline-stack-protectors.c > fails on windows because I redirect stdout to /dev/null. How doe

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added a comment. In phab here, it looks like my newly added clang/test/Frontend/optimization-remark-missed-inline-stack-protectors.c fails on windows because I redirect stdout to /dev/null. How does that work for other tests? I see other tests in that dir write to /dev/null.

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:1901-1902 + // caller was explicitly annotated as nossp. + if (Caller.hasFnAttribute(Attribute::NoStackProtect)) +return; // If upgrading the SSP attribute, clear out the old SSP Attributes fir

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

spatel added a comment. In D87188#2348326 , @nikic wrote: > Reopening this so we don't forget... > > I believe @spatel is working on the cost modelling. I did not have much luck > tracking down the miscompile, at least did not spot anything incriminating

[PATCH] D89980: [hip] Remove kernel argument coercion.

tra added a comment. Are there any tests to illustrate what this change does to IR or generated code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 ___ cfe-comm

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tra added a comment. In D89974#2348310 , @rnk wrote: > Lastly, if those things don't work, there is the `CCC_OVERRIDE_OPTIONS` > environment variable, so the user always has that escape hatch. A separate > environment variable would also be fine. It remi

[PATCH] D89897: [AIX] Emit error for -G option on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba98433971f: [AIX] Emit error for -G option on AIX (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89897/new/ https://reviews.llvm

[clang] 0ba9843 - [AIX] Emit error for -G option on AIX

Author: Xiangling Liao Date: 2020-10-22T16:16:39-04:00 New Revision: 0ba98433971f6aa7cf4dc2befe7b5446d25d5956 URL: https://github.com/llvm/llvm-project/commit/0ba98433971f6aa7cf4dc2befe7b5446d25d5956 DIFF: https://github.com/llvm/llvm-project/commit/0ba98433971f6aa7cf4dc2befe7b5446d25d5956.diff

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic reopened this revision. nikic added a comment. This revision is now accepted and ready to land. Reopening this so we don't forget... I believe @spatel is working on the cost modelling. I did not have much luck tracking down the miscompile, at least did not spot anything incriminating in t

[PATCH] D88659: [NFC] Fix the definition of SuitableAlign

Xiangling_L closed this revision. Xiangling_L added a comment. Manually close the revision after landing it upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 ___ cfe-commits mailing list cfe-co

[clang] 57cdc52 - Initial support for vectorization using Libmvec (GLIBC vector math library)

Author: Venkataramanan Kumar Date: 2020-10-22T16:01:39-04:00 New Revision: 57cdc52c4df0a8a6835ddeede787b23c0ce9e358 URL: https://github.com/llvm/llvm-project/commit/57cdc52c4df0a8a6835ddeede787b23c0ce9e358 DIFF: https://github.com/llvm/llvm-project/commit/57cdc52c4df0a8a6835ddeede787b23c0ce9e35

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

This revision was automatically updated to reflect the committed changes. Closed by commit rG57cdc52c4df0: Initial support for vectorization using Libmvec (GLIBC vector math library) (authored by venkataramanan.kumar.llvm, committed by spatel). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

rnk added a comment. My opinion carries less weight since I don't use CUDA, but I agree with everything Art said. Here's some input, if it helps. I like the `PATH` search for `ptxas` as a way to make things work out of the box as often as possible. I don't like the idea of CMake auto-detecting

[PATCH] D86230: [SourceManager] Skip module maps when searching files for macro arguments

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1764 if (Entry.isFile()) { - SourceLocation IncludeLoc = Entry.getFile().getIncludeLoc(); + auto File = Entry.getFile(); + if (File.getFileCharacteristic() == C_User_ModuleMap || -

[PATCH] D89982: [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: krememek, vsavchenko, NoQ, martong, steakhal. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao created this revision. hliao added reviewers: arsenm, tra, rjmccall, yaxunl. Herald added subscribers: cfe-commits, kerbowa, nhaehnle, jvesely. Herald added a project: clang. hliao requested review of this revision. Herald added a subscriber: wdng. - If an aggregate argument is indirectly ac

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68486f9c3a50: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC (authored by kbobyrev). Repository: rG LLVM Github Monorepo C

[clang-tools-extra] 68486f9 - [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

Author: Kirill Bobyrev Date: 2020-10-22T21:47:48+02:00 New Revision: 68486f9c3a509cdb23451a488f16c530919bab70 URL: https://github.com/llvm/llvm-project/commit/68486f9c3a509cdb23451a488f16c530919bab70 DIFF: https://github.com/llvm/llvm-project/commit/68486f9c3a509cdb23451a488f16c530919bab70.diff

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kbobyrev updated this revision to Diff 300080. kbobyrev added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89852/new/ https://reviews.llvm.org/D89852 Files: clang-tools-extra/clangd/index/remote/marshalling/Ma

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kbobyrev updated this revision to Diff 300079. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve post-LGTM comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89852/new/ https://reviews.llvm.org/D89852 Files: clang-

[clang] e787022 - [SourceManager] Skip module maps when searching files for macro arguments

Author: Jan Korous Date: 2020-10-22T12:36:51-07:00 New Revision: e7870223d8b586cd89ffc7fddd63bc40447bd3fb URL: https://github.com/llvm/llvm-project/commit/e7870223d8b586cd89ffc7fddd63bc40447bd3fb DIFF: https://github.com/llvm/llvm-project/commit/e7870223d8b586cd89ffc7fddd63bc40447bd3fb.diff LO

[PATCH] D86230: [SourceManager] Skip module maps when searching files for macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7870223d8b5: [SourceManager] Skip module maps when searching files for macro arguments (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commi

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tra added a comment. In D89974#2348181 , @Hahnfeld wrote: > Don't we already have this via `PATH`? At least that was my motivation back > then and it worked without problems. We do and it should indeed work for the tests. Setting an environment variable

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81e5f298c431: [clangd] Give the server information about client'

[clang-tools-extra] 81e5f29 - [clangd] Give the server information about client's remote index protocol version

Author: Kirill Bobyrev Date: 2020-10-22T21:35:18+02:00 New Revision: 81e5f298c431555d809f898c196945ca879c1150 URL: https://github.com/llvm/llvm-project/commit/81e5f298c431555d809f898c196945ca879c1150 DIFF: https://github.com/llvm/llvm-project/commit/81e5f298c431555d809f898c196945ca879c1150.diff

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. In D89862#2348173 , @kbobyrev wrote: > Add package versioning and make current version v1. Sorry, I didn't mean in this patch - seems n

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:330 double>::type remquo(__T1 __x, __T2 __y, int *__quo) { return std::remquo((double)__x, (double)__y, __quo); tra wrote: > jdoerfert wrote: > > The template overload I

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1020-1023 +// Resume the default rounding and exception modes. +NewFPFeatures.setRoundingModeOverride( +llvm::RoundingMode::NearestTiesToEven); +NewFPFeatures.setFPExceptionModeOverride(Lan

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:330 double>::type remquo(__T1 __x, __T2 __y, int *__quo) { return std::remquo((double)__x, (double)__y, __quo); jdoerfert wrote: > The template over

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2348176 , @tra wrote: > CUDA path is sort of a global configuration parameter for all CUDA > compilations. Perhaps we should consider allowing the user to specify a CUDA > search path candidate via environment variable

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tra added a comment. > Shortcomings in the testrunner don't seem like a reason to introduce new > build-time configured default search paths into the driver. +1 The root of the problem is that we rely on CUDA SDK as the external dependency and we have no way to reliably predict where the user

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev updated this revision to Diff 300066. kbobyrev added a comment. Add package versioning and make current version v1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://reviews.llvm.org/D89862 Files: clang-tools-extra/clangd

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. In D82756#2348159 , @dexonsmith wrote: > I have an idea: use `DEFAULT_VALUE` to keep current behaviour. Here's an > example to demonstrate. Downside of this is that it's error prone, because it requires for correctness (but d

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. I have an idea: use `DEFAULT_VALUE` to keep current behaviour. Here's an example to demonstrate. `cl_mad_enable` is implied by `OPT_cl_unsafe_math_optimizations` or `OPT_cl_fast_relaxed_math`. Instead of setting the default value to `"false"` it could be set to `"Co

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2348124 , @jdoerfert wrote: > I thought, right now we would configure clang with a cuda path XYZ If you speak of the current state in the repository, AFAICT, Clang doesn't know about a CUDA installation that CMake may

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

jdoerfert added a comment. In D89971#2347909 , @tra wrote: >> The template overload > > function overload. > >> is still hidden behind an ifdef for OpenMP. In the >> future we probably want to remove the ifdef but that requires further >> testing. > > I do

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

jdoerfert added a comment. > I think the default should still let clang search for CUDA or require the > user to provide correct CUDA path. "Use CUDA path discovered by CMake at > build time" should be a non-default configuration option if/when it's needed > and appropriate. > Having an opti

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); if (!Path.endswith(PosixSepara

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kadircet added a comment. > I thought the point of the comment was us not handling it properly rather > than LSP not supporting it (e.g. LSP does support Operator but we do not). > Then, the comment about ctor and dtor being indistinguishable probably > belongs to Protocol.h/cpp and SymbolKind

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov accepted this revision. emankov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77 +return CudaVersion::CUDA_102; + if (raw_version < 11010) +return CudaVersion::CUDA_110; + return CudaV

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bc02e892f54: [SystemZ][z/OS] Set short-enums as the default for z/OS (authored by Jonathan.Crowther, committed by abhina.sreeskantharajan). Reposit

[clang] 9bc02e8 - [SystemZ][z/OS] Set short-enums as the default for z/OS

Author: Jonathan Crowther Date: 2020-10-22T14:15:58-04:00 New Revision: 9bc02e892f54b37031dd81cfc4485d86cee8c757 URL: https://github.com/llvm/llvm-project/commit/9bc02e892f54b37031dd81cfc4485d86cee8c757 DIFF: https://github.com/llvm/llvm-project/commit/9bc02e892f54b37031dd81cfc4485d86cee8c757.d

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

Jonathan.Crowther updated this revision to Diff 300050. Jonathan.Crowther added a comment. Forgot to set the repository for my last patch. No code changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89801/new/ https://reviews.llvm.org/D89801 Fi

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300049. miyuki added a comment. Reverted accidentally removed chunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69844/new/ https://reviews.llvm.org/D69844 Files: clang/include/clang/Basic/SourceLocation.h

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur added a comment. The host's build environment already influences the compiler's defaults, e.g. D88929 . Especially libomptarget heavily uses it, and I would argue that these should be consistent, unless explicitly overwritten. However, I see that Ope

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tambre added a comment. I echo @tra's concerns. Having an option for a vendor to append/prepend a toolkit search location seems useful, but currently this seems more like a workaround for an explicit CUDA toolkit path not being passed to the testsuite. Shortcomings in the testrunner don't seem l

  1   2   >