craig.topper added inline comments.

================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp:354
+  else if (Flags & X86::Force_VEX2Encoding)
+    O << "\t{vex2}";
+  else if (Flags & X86::Force_VEX3Encoding)
----------------
craig.topper wrote:
> Is it important that we use {vex2} instead of just treating it as {vex}?
I guess we'd actually have to print {vex2} instead of {vex} for compatibility 
with older versions of GNU assember that don't support {vex}. So I guess maybe 
they should be different as much as I hate wasting flags


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90009/new/

https://reviews.llvm.org/D90009

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to