jdoerfert added a comment.

> I think the default should still let clang search for CUDA or require the 
> user to provide correct CUDA path. "Use CUDA path discovered by CMake at 
> build time" should be a non-default configuration option if/when it's needed 
> and appropriate.



> Having an option for a vendor to append/prepend a toolkit search location 
> seems useful, but currently this seems more like a workaround for an explicit 
> CUDA toolkit path not being passed to the testsuite.
> Shortcomings in the testrunner don't seem like a reason to introduce new 
> build-time configured default search paths into the driver.

I thought, right now we would configure clang with a cuda path XYZ and the 
clang we build still will lookup the default path instead. This requires you to 
specify XYZ when compiling/linking as well in order to not accidentally pick up 
a different cuda installation (or none at all). Maybe I misunderstood but if I 
didn't, the behavior we have right now seems wrong or at least incomplete. I 
should be able to build a clang on a system with a non-default cuda 
installation that will work "out-of-the-box" for users as it has the cuda path 
"backed-in". Again, I might misunderstand all this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89974/new/

https://reviews.llvm.org/D89974

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to