sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed.
In D89862#2348173 <https://reviews.llvm.org/D89862#2348173>, @kbobyrev wrote: > Add package versioning and make current version v1. Sorry, I didn't mean in this patch - seems not that related.... up to you whether to tie them together. I don't think we need to put the actual messages into versioned namespaces, it makes a mess of the code. (We may need to do this later for some messages if we actually make use of this versioning, but we should pay for it if we use it - moving messages between namespaces is a backwards-compatible change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://reviews.llvm.org/D89862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
