JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Basic/SourceManager.h:118 + private: + unsigned *Storage = nullptr; + }; ---------------- I guess it's implicit in the implementation, but maybe it's worth adding a comment describing the layout (first element is the size, elements at index i are at index i+1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89913/new/ https://reviews.llvm.org/D89913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
