hubert.reinterpretcast added inline comments.
================
Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:20
+// RUN: FileCheck -check-prefixes=COMMON-IR,VISIBILITY-IR %s
+
+int x = 66;
----------------
There's no testing for the interaction with `-mignore-xcoff-visibility`.
================
Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:29
+}
+
+// COMMON-ASM: mflr 0
----------------
The general issue is that the `nop` instruction is being omitted even when the
visibility information is not generated into the object file. This is also a
problem when the visibility is applied in the source code:
```
int x = 66;
#pragma GCC visibility push(hidden)
__attribute__((__noinline__)) inline void f() {
x = 55;
}
#pragma GCC visibility pop
int bar() {
f();
return x;
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89986/new/
https://reviews.llvm.org/D89986
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
