OikawaKirie added a comment.

Since `SymbolRef` is just a `const SymExpr *` in the current codebase, I'd 
prefer using `const SymExpr *` directly, just like how `MemRegion` is used, 
which would be clearer than both `SymbolRef` and `SymExprRef` as far as I am 
thinking.

Different from `ProgramStateRef` which is an alias to `IntrusiveRefCntPtr`, or 
`StoreRef` which is a wrapper object, an alias to a `const SymExpr *` makes no 
sense to me.

And this is also where I have been confused for a long while.

Or on the opposite, do we also need a similar alias for a `const MemRegion *`, 
maybe say `MemRegionRef`? After all, it is shorter. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89987/new/

https://reviews.llvm.org/D89987

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to