Re: Many fixes for Stage

2015-10-02 Thread Thorsten Zachmann
Hello David, On 2015-10-02 09:52, David Faure wrote: I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial

Re: Review Request 125495: Fix empty animation steps when removing animations.

2015-10-02 Thread Thorsten Zachmann
. Boudewijn can you please port forward. - Thorsten Zachmann On Oct. 2, 2015, 9:25 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125494: PictureShapeConfigWidget: ensure we only select existing files.

2015-10-02 Thread Thorsten Zachmann
. Boudewijn can you please forward port the fixes. - Thorsten Zachmann On Oct. 2, 2015, 9:23 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125492: Remove AnimationTmpData struct, take two pointers for output values instead.

2015-10-02 Thread Thorsten Zachmann
patch. Boudewijn can you please forward port the patch. - Thorsten Zachmann On Oct. 2, 2015, 9:16 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125491/#review86271 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9

Re: Review Request 125490: Make Esc stop the presentation also in the main view.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125490/#review86272 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9

Re: Review Request 125488: Avoid hitting assert in QPainter when CropWidget tries to paint a null image rect.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125488/#review86273 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9

Re: Review Request 125489: Cleanup KActionMenu usage: activated() is never emitted, member var not needed.

2015-10-02 Thread Thorsten Zachmann
Start Presentation button without extending the submenu. - Thorsten Zachmann On Oct. 2, 2015, 9:09 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Many questions for Stage

2015-10-04 Thread Thorsten Zachmann
Hello David, On Friday, October 02, 2015 09:54:59 AM David Faure wrote: > Here are some questions to ensure I won't change behavior that was there on > purpose, or that I didn't miss something obvious: > > * Shape animations: Move up / Move down doesn't move the setting "start on > mouse click /

Re: Review Request 125510: Add KPrShapeAnimations::dump() for debugging the animation tree.

2015-10-04 Thread Thorsten Zachmann
- > > (Updated Oct. 3, 2015, 6:15 p.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- > > Add KPrShapeAnimations::dump() for debugging the animation tree. >

Re: Review Request 125493: PictureShapeConfigWidget: add error handling to KIO::Job.

2015-10-05 Thread Thorsten Zachmann
On 2015-10-05 12:44, David Faure wrote: On Monday 05 October 2015 10:30:04 Boudewijn Rempt wrote: Sorry, was waiting for Zagge. No problem. Please note that these are waiting for review too: REVIEW: 125490 this one already has a ship it REVIEW: 125489 Here I had not noticed that

KWPageManager::pages question

2015-12-04 Thread Thorsten Zachmann
Hello, when working on getting cstester ported I noticed that the pages are in a random oder all the time. Looking at the code I see that the pages are stored in q QHash and it seems that at least in Qt5 the order is not always the same in every run. In the header it is says that the pages a

Re: KWPageManager::pages question

2015-12-05 Thread Thorsten Zachmann
On Saturday, December 05, 2015 02:24:43 PM Friedrich W. H. Kossebau wrote: > Hi Thorsten, > > Am Samstag, 5. Dezember 2015, 06:24:11 schrieb Thorsten Zachmann: > [snip] > > > Is it ok to add that or is the comment wrong and I could use the sort > > inside cstester. I d

Re: Applications rename

2010-12-14 Thread Thorsten Zachmann
On Tuesday, December 14, 2010 21:01:20 Cyrille Berger Skott wrote: > On Sunday 05 December 2010, Cyrille Berger Skott wrote: > > Hi, > > > > I know that you might be anxious to rename applications in git, asap. But > > I would want to have a synchronize effort, especially with respect to > > trans

Re: Names of the binaries

2010-12-19 Thread Thorsten Zachmann
On Sunday, December 19, 2010 16:11:14 Jaroslaw Staniek wrote: > On 19 December 2010 15:02, Cyrille Berger Skott wrote: > > On Saturday 18 December 2010, Jaroslaw Staniek wrote: > >> I agree with the intention. Since you mentioned the tab completion, > >> name length does not matter that much, so I

Developer Sprint

2010-12-21 Thread Thorsten Zachmann
Hello all, I would like to organize the first calligra developer sprint. I have set up doodle so everybody can give their prefered dates for a sprint. We had a talk to Mirko from KDAB last week and they are willing to host the event in their office in Berlin. The dates reflect when their office

Re: Developer Sprint

2010-12-21 Thread Thorsten Zachmann
On Tuesday, December 21, 2010 14:04:34 Inge Wallin wrote: > On Tuesday, December 21, 2010 11:51:25 Thorsten Zachmann wrote: > > > So lets get started by filling out the doodle. > > Hmm, why no 19-20 feb? And I think we may need more dates in march. That are the dates

problem linking plan

2010-12-21 Thread Thorsten Zachmann
Hello Dag, I have the attached linker error when I try to build calligra. Can you please have a look. Thanks, Thorsten Linking C shared library ../../../../../../lib/liblibrcps_plan.so

Re: Developer Sprint

2010-12-23 Thread Thorsten Zachmann
Hello all, as some already asked for more dates I have contacted Mirko again about dates in March. He already answerded back I just need to check that I understood it correctly. It looks like I will need to create a new doodle for the dates then again as I have found no option to add stuff t

Re: Developer Sprint

2010-12-25 Thread Thorsten Zachmann
Hello all, > I would like to organize the first calligra developer sprint. I have set up > doodle so everybody can give their prefered dates for a sprint. We had a > talk to Mirko from KDAB last week and they are willing to host the event > in their office in Berlin. The dates reflect when their o

Re: Developer Sprint

2010-12-26 Thread Thorsten Zachmann
On Sunday, December 26, 2010 19:57:23 Cyril Oblikov wrote: > 2010/12/26 Boudewijn Rempt : > > Arrival on Friday, Saturday, departure Sunday afternoon or evening is > > most usual. For visas we really need tot take action asap indeed, for > > you, but also for both Dmitry's. > > As I am from Belaru

Re: Review Request: Few fixes to pathshape/enhancedpath

2010-12-27 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100254/#review642 --- plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp

Re: Developer Sprint

2010-12-27 Thread Thorsten Zachmann
Hello all, > I have created a new doodle to add 3 more dates in march and april where > the office is available to. > > http://www.doodle.com/wdipfrubwsrx78mm > > Everybody please move your data from the old doodle to the new doodle. I have started a wiki page about the Sprint. Not much informa

Re: Review Request: Force no backgound on connection shapes

2010-12-28 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100259/#review651 --- Ship it! Looks good. - Thorsten On 2010-12-28 19:13:58, Jan H

Re: Review Request: calligra helper app

2010-12-29 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100267/#review665 --- flow/src/part/flow.desktop

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-08 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/#review790 --- If you convert a list like that is the file openable by OO and lo

Re: Developer Sprint

2011-01-08 Thread Thorsten Zachmann
Hello all, > > I would like to organize the first calligra developer sprint. I have set up > doodle so everybody can give their prefered dates for a sprint. We had a > talk to Mirko from KDAB last week and they are willing to host the event > in their office in Berlin. The dates reflect when their

Missing signals

2011-01-08 Thread Thorsten Zachmann
Hello all, I have seen the following error messages when debugging something else. Can this connections be removed? Object::connect: No such signal SimpleParagraphWidget::paragraphStyleSelected(KoParagraphStyle *) in /home/tz/develop/kde/git/calligra/plugins/textshape/TextTool.cpp:1600 Object:

Re: Developer Sprint

2011-01-08 Thread Thorsten Zachmann
Hello all, On Sunday, January 09, 2011 07:09:13 Yue Liu wrote: > that is the old doodle like... sorry for that the link should have been http://www.doodle.com/wdipfrubwsrx78mm Thorsten ___ calligra-devel mailing list calligra-devel@kde.org https://mai

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-09 Thread Thorsten Zachmann
> On Jan. 9, 2011, 4:34 a.m., Thorsten Zachmann wrote: > > filters/words/msword-odf/texthandler.cpp, line 1469 > > <http://git.reviewboard.kde.org/r/100306/diff/3/?file=6399#file6399line1469> > > > > How about giving the property directly in the function call

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-09 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/#review824 --- Ship it! Feel free to use QString if you prefer that over the co

mailing list visibility

2011-01-09 Thread Thorsten Zachmann
Hello, the mailing list calligra-devel is not shown in lists.kde.org but it makes no longer sense to not show it. Not sure who can change that therfore this mail. Thorsten ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/m

Re: Developer Sprint

2011-01-10 Thread Thorsten Zachmann
On Monday, January 10, 2011 15:09:53 Boudewijn Rempt wrote: > On Sunday 09 January 2011, Thorsten Zachmann wrote: > > Hello all, > > > > > I would like to organize the first calligra developer sprint. I have > > > set up doodle so everybody can give their prefered

Re: Configuration dialogs for Calligra Applications

2011-01-12 Thread Thorsten Zachmann
On Thursday, January 13, 2011 07:43:36 Shantanu Tushar Jha wrote: > Hi, > I am a new contributor to Calligra and was trying to resolve > https://bugs.kde.org/show_bug.cgi?id=260516 . I found while discussing on > IRC that the feature is already implemented, and only configuration options > are

Re: Don't show template selection ui any longer

2011-01-13 Thread Thorsten Zachmann
On Thursday, January 13, 2011 23:40:25 Sebastian Sauer wrote: > Hi, > > please find attached a patch that disables the templates-dialog per default > for Calligra words and tables. Stage is not changed since imho the default > empty template doesn't really make sense for presentations. > > What d

Calligra Sprint 1.4.-3.4.

2011-01-14 Thread Thorsten Zachmann
Hello all, looks like not everybody has filled out http://community.kde.org/Calligra/Meetings/Begin_2011_meeting#Attendance yet. This is a reminder to fill it out by the end of the week (16.1.). The information is needed so that we can get the approval of the costs by the e.V. board. So if yo

Re: Preventing building inside the source directory

2011-01-15 Thread Thorsten Zachmann
On Saturday, January 15, 2011 15:43:12 Cyrille Berger Skott wrote: > Hi, > > I would like to know if there are any objections on preventing building > calligra in the source directory ? I don't know any usecase for mixing > build files with source files, and it is rather significant problems > (in

cstester - a tool for testing loading and painting of documents

2011-01-18 Thread Thorsten Zachmann
Hello all, I'm currently working as part of my job for Nokia on cstester a tool to test loading and painting for stage, tables and words. The aim of the tool is to make sure there are no regressions added when features are modified. This is done by loading the document and comparing some pre ge

Re: cstester - a tool for testing loading and painting of documents

2011-01-18 Thread Thorsten Zachmann
Hello, On Tuesday, January 18, 2011 14:17:00 Ganesh Paramasivam wrote: > Just a thought ( If this tool development is still in a early phase ). > > Wouldn't this be easier with PDF instead of JPG. PDF ( If I'm right ) > is nothing but a description of the layout data and handling PDF is > more pr

Re: cstester - a tool for testing loading and painting of documents

2011-01-18 Thread Thorsten Zachmann
Hello, On Tuesday, January 18, 2011 14:21:44 Boudewijn Rempt wrote: > On Tuesday 18 January 2011, Thorsten Zachmann wrote: > > Hello all, > > > > I'm currently working as part of my job for Nokia on cstester a tool to > > test loading and painting for stage,

Re: cstester - a tool for testing loading and painting of documents

2011-01-18 Thread Thorsten Zachmann
On Tuesday, January 18, 2011 14:24:38 Inge Wallin wrote: > For Words, how about adding a dump of the text layout and compare > that? That should be easier (and faster!) than generating and comparing > bitmaps. The bitmaps themselves would also not give much added > information, especially if the

Re: cstester - a tool for testing loading and painting of documents

2011-01-18 Thread Thorsten Zachmann
On Tuesday, January 18, 2011 14:51:25 Cyrille Berger Skott wrote: > Hi, > > I had a similar idea. But instead of testing the exact rendering, which is > rather fragile, my idea was to implement a special QPaintEngine (and > associated QPaintDevice), that would record as text the drawing commands.

Re: cstester - a tool for testing loading and painting of documents

2011-01-19 Thread Thorsten Zachmann
On Wednesday, January 19, 2011 09:37:57 Alfredo Beaumont wrote: > Asteazkena 19 Urtarrila 2011(e)an, Thorsten Zachmann(e)k idatzi zuen: > > I think using ia virtual image would be the best here so it is also > > possible to run the tests on a different systems. Running

Re: cstester - a tool for testing loading and painting of documents

2011-01-19 Thread Thorsten Zachmann
On Wednesday, January 19, 2011 09:59:10 Inge Wallin wrote: > On Wednesday, January 19, 2011 05:37:40 Thorsten Zachmann wrote: > > Hello, > > > > On Tuesday, January 18, 2011 14:17:00 Ganesh Paramasivam wrote: > > > Just a thought ( If this tool develop

Re: cstester - a tool for testing loading and painting of documents

2011-01-19 Thread Thorsten Zachmann
On Wednesday, January 19, 2011 14:27:07 Inge Wallin wrote: > On Wednesday, January 19, 2011 05:46:04 Thorsten Zachmann wrote: > > On Tuesday, January 18, 2011 14:24:38 Inge Wallin wrote: > > > For Words, how about adding a dump of the text layout and compare > > > th

Re: Review Request: Configuration dialogs for Calligra Applications

2011-01-19 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100406/#review992 --- libs/main/KoConfigurationDialogPage.h

Re: Calligra Sprint 1.4.-3.4.

2011-01-19 Thread Thorsten Zachmann
On Tuesday, January 18, 2011 11:10:12 Boudewijn Rempt wrote: > On Saturday 15 January 2011, Thorsten Zachmann wrote: > > Hello all, > > > > looks like not everybody has filled out > > > > http://community.kde.org/Calligra/Meetings/Begin_2011_meeting#Attendance &g

Re: Cleaning up the paint API of KoShape

2011-01-23 Thread Thorsten Zachmann
On Sunday, January 23, 2011 18:02:53 ja...@gmx.net wrote: > On Sunday 23 January 2011 15:36:15 Inge Wallin wrote: > > There is a big wart on the KoShape API and that is the one for painting. > > > > Currently we have these two functions: > > virtual void paint(QPainter &painter, const KoViewConve

Re: Subject for usability testing

2011-01-23 Thread Thorsten Zachmann
On Saturday, January 22, 2011 16:02:31 Thomas Pfeiffer wrote: > Hi all, > as those of you who have been on #calligra today probably already know, a > group of students offered to do a usability test as a university project > for us. > > The usbility tests would be conducted in March and the studen

Review Request: Send progress updates more frequently

2011-01-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/ --- Review request for Calligra. Summary --- Send progress updates more f

Re: kplato compile problem on windows

2011-01-24 Thread Thorsten Zachmann
On Monday, January 24, 2011 08:57:15 Pierre Stirnweiss wrote: > As some of may know, I am trying to get Calligra to compile on Windows > MSVC2010. I have encountered a couple of problems, which were easy enough > to solve (with the help of SaroEngels). > The one I am facing now is apparently way mo

Re: Review Request: Table of content for words

2011-01-24 Thread Thorsten Zachmann
t; This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100421/ > ------- > > (Updated Jan. 24, 2011, 1:44 p.m.) > > > Review request for Calligra, Thorsten Zachmann and Casper Boemann. > > > Summary >

Re: Review Request: Table of content for words

2011-01-25 Thread Thorsten Zachmann
> On Jan. 24, 2011, 3:16 p.m., Thorsten Zachmann wrote: > > libs/kotext/KoTableOfContentsGeneratorInfo.cpp, line 132 > > <http://git.reviewboard.kde.org/r/100421/diff/2/?file=7443#file7443line132> > > > > can there be only one index-source-style? If so KoXml

Re: tools docker etc in plan

2011-01-25 Thread Thorsten Zachmann
On Tuesday, January 25, 2011 14:57:07 Cyrille Berger Skott wrote: > On Tuesday 25 January 2011, Sven Langkamp wrote: > > On Tue, Jan 25, 2011 at 10:49 AM, Dag Andersen wrote: > > > Atm I don't have any use for the tools docker nor actually any other > > > docker except the Scripting docker in plan

Re: cstester - a tool for testing loading and painting of documents

2011-01-25 Thread Thorsten Zachmann
Hi all, I have improved cstester to also support words supported files and refactored it a bit to be more modular. I would like to merge it to master. Anybody agains that? Thorsten ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kd

Re: Review Request: Moving anchor strategy into text shape

2011-01-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100442/#review1086 --- I just added some small comments mostly about the style. Would b

Re: Review Request: Complete support for ODF glue points

2011-01-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/#review1085 --- Very nice and impressive work. That are some comments on the cod

Re: Review Request: Complete support for ODF glue points

2011-01-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/#review1087 --- Some things I notices when testing -I'm did not find out on how

Review Request 119138: Fix Bug 334832

2014-07-05 Thread Thorsten Zachmann
, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120010: Allow to exit text-edit mode by pressing Escape.

2014-08-30 Thread Thorsten Zachmann
. - Thorsten Zachmann On Aug. 30, 2014, 9:03 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120011: Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage.

2014-09-03 Thread Thorsten Zachmann
. Thanks for the patch. - Thorsten Zachmann On Aug. 30, 2014, 9:10 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-26 Thread Thorsten Zachmann
plugins in the constructor and not in componentData as it was done before? As now there is the need for another variable. - Thorsten Zachmann On Sept. 24, 2014, 9:24 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an auto

Re: Review Request 119138: Fix Bug 334832

2014-10-15 Thread Thorsten Zachmann
/ Testing --- Tested with the method to provoke the crash attached to the bugreport. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-10-31 Thread Thorsten Zachmann
uick/CQTextDocumentCanvas.cpp <https://git.reviewboard.kde.org/r/120890/#comment48781> Please move the { up to the end of the previous line qtquick/CQTextToCModel.cpp <https://git.reviewboard.kde.org/r/120890/#comment48782>

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-07 Thread Thorsten Zachmann
sensible to me. - Thorsten Zachmann On Nov. 4, 2014, 3:51 p.m., Dan Leinir Turthra Jensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Calligra Maintainers - status updated - more applications about to be freezed

2014-12-15 Thread Thorsten Zachmann
On Monday, December 15, 2014 02:01:03 PM Friedrich W. H. Kossebau wrote: > Stage has my interest from ODF point of view, I really would like some > Qt/KF- based modules for ODP. And Stage itself is also used inside Calligra > Gemini, so Leinir surely also will do some care/enhancement bits there. S

Review Request 121733: Fix crash reported in bug 342222

2014-12-28 Thread Thorsten Zachmann
pasted text to it. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 121733: Fix crash reported in bug 342222

2014-12-29 Thread Thorsten Zachmann
00a1e68 Diff: https://git.reviewboard.kde.org/r/121733/diff/ Testing --- Opened a .kra file with a text shape and pasted text to it. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121733: Fix crash reported in bug 342222

2014-12-30 Thread Thorsten Zachmann
://git.reviewboard.kde.org/r/121733/diff/ Testing --- Opened a .kra file with a text shape and pasted text to it. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Thorsten Zachmann
Hello Stefano, > Hello, we have a problem in Krita with drawing a polygon or a bezier curve > (or basicly anything that uses KoPathShape) in a vector layer, then > transform it so that the lines increase their thickness, then save the file > in .kra format and then reload it: the thickness is not

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-26 Thread Thorsten Zachmann
ld be {} around single line while words/part/KWRootAreaProviderTextBox.cpp <https://git.reviewboard.kde.org/r/122266/#comment51846> There should be {} around single line if. - Thorsten Zachmann On Jan. 26, 2015, 11:17 p.m., Camilla Boemann wrote: > > -

Re: Review Request 122584: Use shared pointers for markers.

2015-02-15 Thread Thorsten Zachmann
ckout. But this does not solve the real problem. And that is that the collection is deleted before the shapes are deleted. I guess if you fix it like that we will have quite some other places too where it can crash as the collection is deleted to early. Otherwise the patch looks ok. - Tho

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread Thorsten Zachmann
Hello, > > I say it should be done now, and be done to 2.9 too > > And I almost don't think maintainers should be able to say no. The long term > goal of having a clean codebase is more important than short term issue > with git blame (have a separate permanent checkout before this revision > wh

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-03-09 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122867/#review77243 --- Ship it! The patch looks good to me. - Thorsten Zachmann

Re: How to modify or create my own slide layouts in Stage?

2015-03-22 Thread Thorsten Zachmann
Hello Henrik, On Friday, March 20, 2015 12:07:48 PM Henrik Ingo wrote: > First, I'd like to congratulate the Calligra developers for getting > this far with a promising (and actively developed!) open source office > suite! Thanks a lot for you kind words. > It seems you are right now in that ago

Re: Review Request 123146: calligra sheets: do not use VerPattern twice for cell pattern

2015-03-26 Thread Thorsten Zachmann
that the solid one in just before the no brush pattern. - Thorsten Zachmann On March 27, 2015, 3:27 a.m., Boris Egorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 123352: Fix DockerStylesComboModel

2015-04-13 Thread Thorsten Zachmann
Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-15 Thread Thorsten Zachmann
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123352/#review79010 --- On April 13, 2015, 2:01 p.m., Thorsten Zachmann wrote: > > -

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-15 Thread Thorsten Zachmann
://git.reviewboard.kde.org/r/123352/diff/ Testing --- Tested adding of various style with different names. Worked quite nicly Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-16 Thread Thorsten Zachmann
/StylesModel.h d15651f plugins/textshape/dialogs/StylesModel.cpp f996824 Diff: https://git.reviewboard.kde.org/r/123352/diff/ Testing --- Tested adding of various style with different names. Worked quite nicly Thanks, Thorsten Zachmann

Re: Review Request 123440: Load defaults markers.xml directly via "data" resource dirs, not "styles"

2015-04-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123440/#review79405 --- Ship it! Looks good. - Thorsten Zachmann On April 20

Re: 2.9.3 reminder

2015-04-25 Thread Thorsten Zachmann
On Friday, April 24, 2015 11:04:30 PM Jaroslaw Staniek wrote: > We need changelogs, please... > Stage: Fix crash after empty custom slide show. 34cfe3dc353669d1f167f6df91ae14d6e6785224 Stage / Flow: Fix showing of thumbnail after updating master page 8784da05a5d76fc9bc4a10220d87fee77ecb018c f53

Review Request 123660: Improve KoFindToolbar

2015-05-06 Thread Thorsten Zachmann
ca12462 libs/main/KoFindToolbar_p.h 54ecaf5 Diff: https://git.reviewboard.kde.org/r/123660/diff/ Testing --- Tested interactive searching. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 123660: Improve KoFindToolbar

2015-05-06 Thread Thorsten Zachmann
marked as submitted. Review request for Calligra. Changes --- Submitted with commit 1f26d5d084f608ada048b66edb3ce6e949e4f5cb by Thorsten Zachmann to branch calligra/2.9. Repository: calligra Description --- The KoFindToolbar is used in words to search the documents. The current

Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers

2015-05-30 Thread Thorsten Zachmann
Just remove it if it no longer works. libs/flake/KoPathShape.cpp (line 54) <https://git.reviewboard.kde.org/r/123955/#comment55472> Don't comment out code. Just remove it if it no longer works. - Thorsten Zachmann On May 30, 2015, 11:04 p.m.,

Re: Review Request 124291: Loop optimalization at table cell formatting

2015-07-15 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124291/#review82560 --- Ship it! Looks good please commit. - Thorsten Zachmann On

Re: Review Request: Complete support for ODF glue points

2011-01-28 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/#review1099 --- Ship it! Works now. I had some problems understanding how to

Calligra Sprint budget approved

2011-01-31 Thread Thorsten Zachmann
Hello all, I'm pleased to inform you that the KDE e.V. board has approved our budget for the KDE sprint. So please everybody go on and order your tickets as soon as possible. Also please update the wiki page with the amount the ticket costs and the time you are arriving/leaving. With the help

Re: Review Request: Send progress updates more frequently

2011-01-31 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/ --- (Updated Feb. 1, 2011, 4:01 a.m.) Review request for Calligra. Changes -

Re: review-request: Calligra Words performance work

2011-01-31 Thread Thorsten Zachmann
Hello Sebastian, On Monday, January 31, 2011 17:00:55 Sebastian Sauer wrote: > Hi *, > > please find attached[1] a patch (diff between master and the > words-layout_performance-sebsauer branch) that improves > layouting-performance of Calligra Words. > void KWTextFrameSet::requestMoreFrames(qr

Review Request:

2011-02-01 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100522/ --- Review request for Calligra. Summary --- This patch implements text o

Re: Review Request: Refactor Text on shape

2011-02-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100522/ --- (Updated Feb. 2, 2011, 3:02 p.m.) Review request for Calligra. Summary (

Re: Calligra Sprint budget approved

2011-02-03 Thread Thorsten Zachmann
Hello Jarek, On Thursday, February 03, 2011 23:13:26 Jaroslaw Staniek wrote: > On 1 February 2011 04:57, Thorsten Zachmann wrote: > > Hello all, > > > > I'm pleased to inform you that the KDE e.V. board has approved our budget > > for the KDE sprint. So pleas

Re: KoXmlWriter::addCompleteElement leaves device open

2011-02-04 Thread Thorsten Zachmann
On Friday, February 04, 2011 23:17:57 David Faure wrote: > I was surprised that the following code (which I'm working on for the > applix filter) ... > > paragraphBuffer.close(); > > bodyWriter->startElement("text:p"); > bodyWriter->addAttribute("text:style-nam

Link error

2011-02-06 Thread Thorsten Zachmann
Hello Cyrille, I have a link error when building pigment. Would be nice if you could have a look. Thanks, Thorsten Linking CXX shared library ../../lib/libpigmentcms.so

Re: unittests

2011-02-07 Thread Thorsten Zachmann
On Monday, February 07, 2011 13:08:17 Boudewijn Rempt wrote: > 218 - libs-flake-TestShapeGroupCommand (Failed) I fixed this test. The tests where totally wrong no idea if that ever could have worked. Thorsten ___ calligra-devel mailing list cal

Re: Calligra Sprint budget approved

2011-02-10 Thread Thorsten Zachmann
Hello all, On Thursday, February 03, 2011 23:13:26 Jaroslaw Staniek wrote: > On 1 February 2011 04:57, Thorsten Zachmann wrote: > > Hello all, > > > > I'm pleased to inform you that the KDE e.V. board has approved our budget > > for the KDE sprint. So pleas

Re: track the active paget between slide sorter and normal view in Stages

2011-02-10 Thread Thorsten Zachmann
Hello Paul, > I essay a patch for the following bug: > > Paul welcome Paul and thanks a lot for your patches. I have attached some comments about your patch at the end of the mail. For the future please use http://git.reviewboard.kde.org/ for posting your patches which makes to review them.

Re: GSoC 2011!

2011-02-10 Thread Thorsten Zachmann
On Thursday, February 10, 2011 21:33:21 todd rme wrote: > On Thu, Feb 10, 2011 at 3:20 PM, C. Boemann wrote: > > On Thursday 10 February 2011 21:15:06 todd rme wrote: > >> On Thu, Feb 10, 2011 at 1:26 PM, todd rme wrote: > >> > On Thu, Feb 10, 2011 at 3:42 AM, Cyrille Berger Skott > >> > > >> >

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1377 --- Can you please wait before committing I would like to review and

  1   2   3   4   5   6   7   >