----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100254/#review642 -----------------------------------------------------------
plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp <http://git.reviewboard.kde.org/r/100254/#comment468> From looking at the spec it is always explicitly written to use clockwise e.g. in V and W command. So my guess is it is counter clockwise. I have send a mail to the ODF TC for clarification. plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <http://git.reviewboard.kde.org/r/100254/#comment467> This code will no longer work when loading the path after the viewBox. - Thorsten On 2010-12-27 21:17:13, Lassi Taneli Nieminen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100254/ > ----------------------------------------------------------- > > (Updated 2010-12-27 21:17:13) > > > Review request for Calligra. > > > Summary > ------- > > Few fixes to pathshape/enhancedpath > 1. In T the parameters are w/h, to get radiuses they should be divided by two > 2. Allow T to have sweep angle to both directions as odf spec does not limit > it to one direction. > 3. The move after T had wrong y axis direction > 4. When loading odf, load viewBox before evaluating path. This because path > may have references to w,h,l,r,t,b and those are defined > from viewBox. > > Feel free to ignore changes to rest of the files. > > > Diffs > ----- > > filters/kpresenter/pptx/PptxXmlSlideReader.cpp 206ccdf > filters/libmsooxml/ComplexShapeHandler.h d1c78e3 > filters/libmsooxml/ComplexShapeHandler.cpp 622af85 > filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h eb03cf9 > filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h d5732fc > filters/libmsooxml/MsooXmlCommonReaderImpl.h 138e797 > filters/libmsooxml/MsooXmlCommonReaderMethods.h e99c747 > filters/libmsooxml/generated/generatedShapes.h f8b3b2a > filters/libmsooxml/generated/generator.cpp 72e8c0a > filters/words/docx/DocxXmlDocumentReader.h d7fb2f5 > filters/words/docx/DocxXmlDocumentReader.cpp 231a3e7 > plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp 7fcd453 > plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 2c26294 > > Diff: http://git.reviewboard.kde.org/r/100254/diff > > > Testing > ------- > > > Thanks, > > Lassi Taneli > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
