Re: [Kexi] Meego 1.1 and Koffice 2.2.95 - No Kexi package

On Sunday, December 12, 2010 01:01:42 am Cyrille Berger Skott wrote: > On Sunday 12 December 2010, Jaroslaw Staniek wrote: > > On 12 December 2010 02:04, Noli Sicad wrote: > > > Hi, > > > > > > I found that koffice and freoffice rpm in this repository state for > > > meego_1.1_core (below). > > >

Re: Unit test coverage

On Sunday, December 12, 2010 01:21:46 am Cyrille Berger Skott wrote: > Hi, > > I have setup a nightly build for calligra, which is intented if you have > heavy unit tests that cannot be run for every commit. And also for unit > test coverage. > > The results is that we currently have a 26% covera

Re: [Kexi] Meego 1.1 and Koffice 2.2.95 - No Kexi package

On Sunday, December 12, 2010 01:40:13 am you wrote: > On 12 December 2010 10:01, Cyrille Berger Skott wrote: > > Well kexi is disabled in TINY. > > That's true but in the url above I see not just freoffice but regular > koffice apps wihout TINY. > If I am not mistaken we would expect regular kexi

Re: Names of the binaries

On Saturday, December 18, 2010 07:59:58 am Inge Wallin wrote: > I think it would be a good idea to prefix our binaries with cs. Examples > would be cswords, cstables and so on. OOo does this with binaries like > oowriter, oocalc, etc. I *think* Libreoffice does the same but I'm not > sure. > > R

Re: Names of the binaries

On Saturday, December 18, 2010 10:18:59 am Jaroslaw Staniek wrote: > On 18 December 2010 16:59, Inge Wallin wrote: > > I think it would be a good idea to prefix our binaries with cs. Examples > > would be cswords, cstables and so on. OOo does this with binaries like > > oowriter, oocalc, etc. I

Re: Review Request: Rename the "table" shape to spreadsheet shape

04:36) > > > Review request for Calligra and Marijn Kruisselbrink. > > > Summary > --- > > As you can see in http://forum.kde.org/viewtopic.php?f=96&t=92343 the table > shape is confused for a text table shape, while it is really a spreadsheet > shape.

Re: calligratables and formula offset

On Tuesday, January 11, 2011 03:50:51 pm David Faure wrote: > Hello, > > I have a question for the applixspread import filter: if I have a formula > like =B1+C1 for A1, > and I want to reuse this formula for A3, I need to somehow change it to > =B3+C3, just like copy/paste would do. Is there some

Re: Review Request 120609: The PixmapCacheSheetView crashes after the getTile API retuns from the QCache the QImage, but its use is deprecated

PixmapCachingSheetView you should probably also just delete that class itself? - Marijn Kruisselbrink On Oct. 16, 2014, 8:11 p.m., Philip Van Hoof wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request: Limit zooming to a minimum and maximum zoom value

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1319 --- libs/widgets/KoZoomAction.cpp

Re: Review Request: Limit zooming to a minimum and maximum zoom value

> On Feb. 9, 2011, 9:25 a.m., Marijn Kruisselbrink wrote: > > libs/widgets/KoZoomAction.cpp, lines 78-85 > > <http://git.reviewboard.kde.org/r/100613/diff/1/?file=8794#file8794line78> > > > > I'm not entirely sure, but doesn't this change the zo

Re: Review Request: Limit zooming to a minimum and maximum zoom value

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1322 --- - Marijn On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote: >

Re: Review Request: Limit zooming to a minimum and maximum zoom value

Hmm, that didn't quite work as intended, I tried to add another comment: "Or probably even something that doesn't hardcode the center to 1, but just interpolates the entire range..." But apparently reviewboard doesn't want me to actually publish that one... Marijn

Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100716/ --- Review request for Calligra. Summary --- This changes KoImageSelectio

Re: Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100716/ --- (Updated Feb. 23, 2011, 11:48 p.m.) Review request for Calligra. Changes

Re: Review Request: Add an initial implementation of KoFind to Tables

5, 2011, 12:42 p.m.) > > > Review request for Calligra and Marijn Kruisselbrink. > > > Summary > --- > > This patch adds an initial implementation of KoFindBase to Tables that can > search through a Tables sheet. It does not yet do highlighting and o

Re: Windows compilation error

When did you last update calligra? And what kdelibs version are you building against? There should be a #if in the code that only uses the (KFileItemList, QSize) arguments for kdelibs versions where that method exist, but somehow that check seems to be failing for you? Marijn On Sunday, May 22

Re: best unittest result ever:

On Wednesday, June 22, 2011 02:32:21 pm Jos van den Oever wrote: > On Wednesday, June 22, 2011 23:25:55 PM Jos van den Oever wrote: > > On Wednesday, June 22, 2011 23:13:40 PM Jos van den Oever wrote: > > > On Wednesday, June 22, 2011 14:51:52 PM Cyrille Berger Skott wrote: > > > > On Wednesday 22

Re: [calligra] libs/main: Show the current working directory by default when starting without args

Why would you want the "current" working directory to be shown when you start an app from the kde menu and/or krunner or any of many other places where you invoke the application without having a clear concept of working directory? This might be a nice feature for people that start stuff from th

Re: Review Request: Fix hyperlink-activation in Tables

ly 7, 2011, 12:47 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus. > > > Summary > --- > > Sometimes hyperlinks are not proper activated (as in executed if you click on > them so that Konqueror or your favorite Webbrowse

Re: Plasma Active Roadmap

On Friday, August 12, 2011 12:01:45 PM Boudewijn Rempt wrote: > For the first release (with Calligra 2.4), open tasks are: > > * integreation with the desktop search system > * include a presentation mode (needs some hacking in stage itself to > reuse stage's presentation mode) * support s

Re: [calligra] filters: Fix bug 276268 - “Format not recongnized” Error is displaying while opening the attached Excel 2010 file

And for documentation sake: The real problem is that the whole relying on QUALIFIED_NAME (and certain hardcoded namespace prefixes) is completely broken by design. There are no elements without namespaces anywhere here, just elements with empty namespace prefixes, but because of the (broken) des

Re: Review Request: Fix wrong position calculations in AbstractSelectionStrategy, SelectionStrategy and DragAndDropStrategy

eviewboard.kde.org/r/102517/ > --- > > (Updated Sept. 2, 2011, 8:03 a.m.) > > > Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus. > > > Summary > --- > > This fixes a crash when sele

Re: Review Request: Fix missing images in excel filter

refactoring of the ODraw handling in the xls filter more straightforward, since there is less special casing/duplication of code. Great. - Marijn Kruisselbrink On Nov. 22, 2011, 5 p.m., Lukáš Tvrdý wrote: > > --- > This is an auto

Re: Review Request: Optimize loading speed of tables

nstead of having the current midString.startsWith() have expression.midRef(i, 10) == QLatin1String("ERROR.TYPE") and similar for the other functions - Marijn Kruisselbrink On Dec. 14, 2011, 11:18 a.m., Thorsten Zachmann wrote: > > ---

Re: Review Request: Optimize loading speed of tables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103408/#review8986 --- Ship it! Ship It! - Marijn Kruisselbrink On Dec. 15, 2011

Re: Review Request: tables documentation update for 2.4

, but in general it looks fine to me. - Marijn Kruisselbrink On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: tables documentation update for 2.4

, but in general it looks fine to me. - Marijn Kruisselbrink On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: tables documentation update for 2.4

--- On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103614/ > --- > > (Updated Jan. 3, 2012, 10:42

Re: Making dbus optional in Calligra

On Tuesday, February 07, 2012 07:59:55 PM Sebastian Sauer wrote: > On 02/07/2012 02:52 PM, Boudewijn Rempt wrote: > > On Tue, 7 Feb 2012, Sebastian Sauer wrote: > >> What I would like to do is to introduce in Calligra a way to > >> completely disable any use of dbus. The target would be to 1) make

Re: Using the Tables brand/trade name for a spreadsheet application

On Thursday, March 08, 2012 04:36:25 AM Sebastian Sauer wrote: > On 03/07/2012 06:10 PM, Algot Runeman wrote: > > On 03/07/2012 09:15 AM, Boudewijn Rempt wrote: > >> On Wed, 7 Mar 2012, Sebastian Sauer wrote: > >>> I really think we should not rename to Abacus if we do not plan to > >>> make some l

Re: Calligra sprint in May?

On Thursday, March 08, 2012 04:31:16 AM Thorsten Zachmann wrote: > On Wednesday, March 07, 2012 08:24:19 Inge Wallin wrote: > > The e.V board has a new policy for sprints that means that you have to > > apply for a budget the quarter before you plan to give a sprint. This > > means that if we want

Re: RC2

So I have to finish renaming calligra tables to calligra sheets before sunday then? Marijn On Thursday, March 08, 2012 09:33:31 AM Cyrille Berger wrote: > Hi, > > since there was some data loss spotted by Thorsten, and now fixed, we are > not going to release the RC1, but I am going to tag a RC

Re: RC2

tually hoping not to have to redo the translations as well > :( > > On Thursday 08 Mar 2012, Burkhard Lück wrote: > > Am Donnerstag, 8. März 2012, 19:15:03 schrieb Marijn Kruisselbrink: > > > So I have to finish renaming calligra tables to calligra sheets before > > >

Re: Review Request: Bug 290656( Meaningless action text in cell context menu) resolved

me. tables/ui/CellToolBase_p.cpp <http://git.reviewboard.kde.org/r/104174/#comment9031> What is this change about? The two extra separator actions don't seem to be used. - Marijn Kruisselbrink On March 6, 2012, 3:50 p.m., Jigar Raisin

Re: RC2

; > On Thursday 08 Mar 2012, Marijn Kruisselbrink wrote: > > Well, if you'd rather do the renaming after RC2 (and before RC3), that is > > fine with me too, then I'll just do the renaming in master first and we > > can merge it to 2.4 after RC2 is tagged. > > >

Re: RC2

I have a patch ready here locally to rename Calligra Tables to Calligra Sheets, I'm just not sure anymore what I should do with it... On Monday, March 12, 2012 02:34:39 AM Marijn Kruisselbrink wrote: > So I'm not sure what you're suggesting then? Release as Calligra Tables

Re: Using the Tables brand/trade name for a spreadsheet application

nce we of course don't want to couse any more confusion than is inherent in using a generic word as name for an application, we've decided to rename Calligra Tables to Calligra Sheets. Regards, Marijn Kruisselbrink Calligra Sheets Maintainer On Wednesday, March 07, 2012 11:18:23 AM Tab

Re: calligra.org/tables needs to be changed to calligra.org/sheets

Also somebody should rename the bugzilla component. Marijn On Wednesday, March 14, 2012 08:28:17 PM Jaroslaw Staniek wrote: > On 14 March 2012 18:36, Friedrich W. H. Kossebau wrote: > > Hi, > > > > now that Calligra Tables officially got renamed to Calligra Sheets, this > > needs to be reflecte

Re: Regarding Proposal

On Friday, March 16, 2012 09:56:27 AM Jaroslaw Staniek wrote: > Jigar, > Cool, that's normal - many ideas, food for thought :_) > > To add even more spice here - pivot tables for database apps (Kexi) > are really appealing (but I think reuse of Sheets pivot tables would > be rather limited becaus

Re: calligra/2.4 build fails

On Friday, March 16, 2012 10:14:24 AM Boudewijn Rempt wrote: > On Friday 16 March 2012 Mar, Dag wrote: > > If I'm not mistaken, something is missing from the 2.4 -> calligra/2.4 > > conversion in sheets/part/View.cpp:1179 > > > > Att patch fixes, but could you check it out Boudewijn, it seems you

Re: Review Request: formulas averageif, averageifs, sumifs, countifs implemented in Calligra Sheets

unit tests. Currently (almost?) every function has several unit tests to test for correctness, so I don't really want new functions that get added to not have at least some basic unit tests. - Marijn Kruisselbrink On April 5, 2012, 12:56 a.m., Nityam V

Re: [calligra] sheets: save shapes with the proper offset when they are cell-anchored

On Saturday, April 07, 2012 10:54:21 AM Inge Wallin wrote: > On Saturday, April 07, 2012 02:58:44 Marijn Kruisselbrink wrote: > > Git commit f64d1b162595753a50367793a96fac6af2083684 by Marijn > > Kruisselbrink. Committed on 07/04/2012 at 02:09. > > Pushed by mkruisselbrin

Re: Review Request: Fix Historical Name of Date Basis and wrong sepperator used in financial.xml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104645/#review12613 --- Ship it! Ship It! - Marijn Kruisselbrink On April 17, 2012

Review Request: change Sheets UI by moving the cell editor out of the cell tool

sheets/ui/ExternalEditor.h ab3ee6d sheets/ui/ExternalEditor.cpp e9f8781 sheets/ui/LocationComboBox.h e666ada sheets/ui/LocationComboBox.cpp 6215039 sheets/ui/Selection.h baa9cdf sheets/ui/Selection.cpp 316a2fc Diff: http://git.reviewboard.kde.org/r/104708/diff/ Testing --- Thank

Review Request: remove one of two copies of KoItemToolTip

). Diffs - libs/main/CMakeLists.txt f4074ea libs/main/KoItemToolTip.h 4e35e1e libs/main/KoItemToolTip.cpp 72b3801 libs/widgets/KoItemToolTip.h 91dd510 libs/widgets/KoItemToolTip.cpp beffbcb Diff: http://git.reviewboard.kde.org/r/104738/diff/ Testing --- Thanks, Marijn Kru

Re: [KDE/Mac] Working kde apps on kde?

I have no idea what is going on there, but I have seen similar errors/warnings when running calligra applications on Android. In that case it seems loading libwordsprivate.so is what triggers similar warnings (of course for different files, since obviously /mach_kernel doesn't exist on android;

Re: calligra:fill-style-name and friends

On Wednesday, May 16, 2012 10:42:38 AM Jos van den Oever wrote: > calligra:fill-style-name: > - > fo:background- color="#00" style:vertical-align="bottom"/> > which points to > >draw:transparency="88%"/> > > (after converting me03_different_color

Re: Important must read: Splitting UI out of KoDocument

On Monday, May 21, 2012 11:17:32 PM C. Boemann wrote: > Such a big branch has a tendency to bit rot quickly so please do your > checking and reviewing quickly so we can merge within a week or so. If we > don't hear from you we will assume you have tested and found no problems. > > It's unlikely th

Re: Important must read: Splitting UI out of KoDocument

On Tuesday, May 22, 2012 08:50:10 PM C. Boemann wrote: > On Tuesday 22 May 2012 20:45:15 Marijn Kruisselbrink wrote: > > On Monday, May 21, 2012 11:17:32 PM C. Boemann wrote: > > > Such a big branch has a tendency to bit rot quickly so please do your > > > checking and

Re: Review Request: Use KoModeBox in Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105175/#review14491 --- Ship it! Ship It! - Marijn Kruisselbrink On June 7, 2012

Re: Review Request: Remove some deprecated calls and fix a typing error

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103057/#review14498 --- Ship it! the tables/sheets changes look good to me. - Marijn

Re: Review Request: rename the app icon of Calligra sheets from kspread to sheets

to me, indeed please backport too. - Marijn Kruisselbrink On July 15, 2012, 6:20 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Enabling Sheets to show plugin items on Configure Sheets/Plugins page

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106220/#review18119 --- Ship it! Looks good to me - Marijn Kruisselbrink On Aug

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

> On Nov. 26, 2012, 6:51 p.m., Thorsten Zachmann wrote: > > sheets/functions/information.cpp, lines 193-201 > > > > > > This seems to be wrong. It should return the number of of documents in > > the vlaue and not t

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107514/#review22776 --- Ship it! Ship It! - Marijn Kruisselbrink On Nov. 29, 2012

Re: Compile errors while trying to build with Windows build of calligrasheetscommon

Old versions of MSVC did not include a definition of atanh (I'm not sure if newer versions do, but at least MSVC 2012 seems to). When building kde applications on windows, wrapper headers are used that make sure among others this symbol exist too (see https://projects.kde.org/projects/kdesupport/kd

Re: Review Request: Move ElapsedTime class to a private header that wont be installed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107717/#review23471 --- Ship it! LGTM - Marijn Kruisselbrink On Dec. 14, 2012, 1

Re: Impementation-dependent casts from uchar to char

On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek wrote: > Hello Marijn, > There are impementation-dependent casts from uchar to char: > Ah yes, that is indeed not good. Since this is your code, could you point me what are these values? > I assume I copied these values from whatever document docu

Re: Impementation-dependent casts from uchar to char

On Wed, Jan 2, 2013 at 2:50 PM, Jaroslaw Staniek wrote: > On 2 January 2013 22:52, Marijn Kruisselbrink > wrote: > > On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek > wrote: > >> > >> Hello Marijn, > >> There are impementation-dependent casts from uch

Re: Review Request 107866: Pivot Tables for Calligra Sheets

- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107866/ > --- > > (Updated Dec. 23, 2012, 9:41 a.m.) > > > Review request for Calligra and Marijn Kruisse

Re: Review Request 107866: Pivot Tables for Calligra Sheets

> On Jan. 14, 2013, 11:17 p.m., Inge Wallin wrote: > > I think it's very high time that somebody who knows Sheets took a look at > > this review request. Nobody should have to wait 3 weeks to get a review, > > especially for something as important as this. >

Re: Review Request 107866: Pivot Tables for Calligra Sheets

criptive names than flag, flag1 and flag2? - Marijn Kruisselbrink On Jan. 15, 2013, 7:29 p.m., Jigar Raisinghani wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 107866: Pivot Tables for Calligra Sheets

> On Jan. 14, 2013, 11:17 p.m., Inge Wallin wrote: > > I think it's very high time that somebody who knows Sheets took a look at > > this review request. Nobody should have to wait 3 weeks to get a review, > > especially for something as important as this. >

Re: Review Request 107866: Pivot Tables for Calligra Sheets

comment that I only did a quick look over for simple style issues so far. I'll try to give more comments on the actual implementation tomorrow. - Marijn Kruisselbrink On Jan. 15, 2013, 7:29 p.m., Jigar Raisinghani wrote: > > --- &

Re: Review Request 108424: updated modebox for words,sheets,author

, but I guess I can live with the change (I'm not a UI guy after all). - Marijn Kruisselbrink On Jan. 15, 2013, 12:34 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 108913: remove explicit, but duplicated passing of parameters xmlWriter & mainStyles in Sheets*::saveOdf(...)

the introduction of OdfSavingContext (and KoShapeSavingContext), so yeah, I think it is a good idea to clean this up a bit. - Marijn Kruisselbrink On Feb. 11, 2013, 8:20 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an

Re: Review Request 109284: Normalize SIGNAL and SLOT signatures in Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109284/#review28558 --- Ship it! Ship It! - Marijn Kruisselbrink On March 4, 2013

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

g/r/109378/#comment21606> what is that number? Can't you use Qt::Key_F2 instead? sheets/ui/CellToolBase.cpp <http://git.reviewboard.kde.org/r/109378/#comment21605> nit: get rid of extra whitespace - Marijn Kruisselbrink On March 9, 2013, 10:37 p.m., Jigar

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

comments, use spaces instead. - Marijn Kruisselbrink On March 10, 2013, 1:39 p.m., Jigar Raisinghani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.re

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

, I don't think the behavior is completely as desired. After clearing all the cells it still enters the editor, while I don't think that should happen. Maybe just an early return from the key press handler would work for this? - Marijn Kruisselbrink On March 10, 2013, 1:52 p

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

ttp://git.reviewboard.kde.org/r/109378/#comment21613> tiny nit, please get rid of the trailing whitespace on this line and the line a bit further down - Marijn Kruisselbrink On March 10, 2013, 2:34 p.m., Jigar Raisinghani wrote: > > ---

Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

same change in 5e2cc2ee27a50806b0c2eb16724ad704a6450d9f for KoToolDocker) Diffs - libs/main/KoModeBox.cpp 91f71e2 Diff: https://git.reviewboard.kde.org/r/118232/diff/ Testing --- Thanks, Marijn Kruisselbrink ___ calligra-devel ma

Re: Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118232/#review58220 ------- On May 20, 2014, 11:42 p.m., Marijn Kruisselbrink wrote: > >

Re: Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

hanks, Marijn Kruisselbrink ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel