----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104738/ -----------------------------------------------------------
Review request for Calligra. Description ------- Somehow we ended up with two copies of the KoItemToolTip class, one in kowidgets and one in komain. (and worse, some bug fixes were only applied to one of the two copies). This fixes that by only having one copy of the class, in the kowidgets library. I copied the komain version there since that version had some bug fixes that the kowidgets version didn't get. The only potential downside to this I can see is that now the class needs to be exported (since the only users of it are in kowidgets and komain, the class wasn't exported before and instead somebody decided to have two copies instead). Diffs ----- libs/main/CMakeLists.txt f4074ea libs/main/KoItemToolTip.h 4e35e1e libs/main/KoItemToolTip.cpp 72b3801 libs/widgets/KoItemToolTip.h 91dd510 libs/widgets/KoItemToolTip.cpp beffbcb Diff: http://git.reviewboard.kde.org/r/104738/diff/ Testing ------- Thanks, Marijn Kruisselbrink
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
