----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103044/#review8400 -----------------------------------------------------------
Ship it! Looks good to me, should also make a future refactoring of the ODraw handling in the xls filter more straightforward, since there is less special casing/duplication of code. Great. - Marijn Kruisselbrink On Nov. 22, 2011, 5 p.m., Lukáš Tvrdý wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103044/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer. > > > Description > ------- > > This patch uses more of the libmso in excel filter. > > So far the pictures were handled as PictureObject class. One problem was that > there was no support for groups for this object. So when you put two images > into groups, they > are not displayed because the anchoring information is saved in different > data-structure - in the > group structure. > > Now I let the records to be handled by libmso, which provides this > functionality. > It supports groups and even graphical styles like like borders etc. > > > This addresses bugs 244862, 262865 and 286607. > http://bugs.kde.org/show_bug.cgi?id=244862 > http://bugs.kde.org/show_bug.cgi?id=262865 > http://bugs.kde.org/show_bug.cgi?id=286607 > > > Diffs > ----- > > filters/libmso/ODrawToOdf.h 0016f8b > filters/libmso/pictures.cpp f8bfa7c > filters/libmso/shapes.cpp db001ee > filters/tables/excel/import/ExcelImport.cpp 0f361a4 > filters/tables/excel/import/ODrawClient.h 83ed45c > filters/tables/excel/import/ODrawClient.cpp 5a6507b > filters/tables/excel/import/excelimporttoods.cc 287aef7 > filters/tables/excel/sidewinder/cell.h f9f7fc3 > filters/tables/excel/sidewinder/cell.cpp 0be93c3 > filters/tables/excel/sidewinder/excel.h 2be1f5a > filters/tables/excel/sidewinder/excel.cpp 92d4a41 > filters/tables/excel/sidewinder/globalssubstreamhandler.h 77c6e3a > filters/tables/excel/sidewinder/globalssubstreamhandler.cpp f9c03b1 > filters/tables/excel/sidewinder/objects.h 2412f07 > filters/tables/excel/sidewinder/objects.cpp ea60560 > filters/tables/excel/sidewinder/sheet.h 060e52e > filters/tables/excel/sidewinder/sheet.cpp b6ecc82 > filters/tables/excel/sidewinder/workbook.h 2e3c2fa > filters/tables/excel/sidewinder/workbook.cpp 9ad61bc > filters/tables/excel/sidewinder/worksheetsubstreamhandler.cpp 2b258ae > > Diff: http://git.reviewboard.kde.org/r/103044/diff/diff > > > Testing > ------- > > I did regression testing against master. My testing set consists of 976 xls > files. > I found only positive changes. > > Missing frames around pictures are displayed now, missing images are > displayed now. > You can test the document. > > > Thanks, > > Lukáš Tvrdý > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
