----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100716/ -----------------------------------------------------------
(Updated Feb. 23, 2011, 11:48 p.m.) Review request for Calligra. Changes ------- It now at least shows the preview inline in the file dialog (when run in KDE), getting rid of the second preview is a bit more difficult due to the async nature of KIO (and the potential for a long wait for a remote image). If you insert a remote image currently the UI will not block, but you just won't see an image in the dialog/will be able to insert an image until the download is completed (you are able to cancel insertion though). I guess we somehow could do this in the background in some other way, but doing that without blocking the UI is tricky. I haven't yet done anything about the size of the preview. Summary ------- This changes KoImageSelectionWidget to no longer be a widget that embeds a KFileWidget, but instead show a KFileDialog to select a file. This should make it for example feel more native when run on windows, as you get a real file dialog. The overall behavior of the widget hasn't really changed with this diff, after selecting a file in the dialog/widget, you still get a preview of the image and can Ok/Cancel it. Diffs (updated) ----- libs/main/KoImageSelectionWidget.h 737ffdc3f655eaffb31eeb569384fe2b6c8aa678 libs/main/KoImageSelectionWidget.cpp 92c6d215b1a4c30607b1855dd517cfbce61bdda7 Diff: http://git.reviewboard.kde.org/r/100716/diff Testing ------- Thanks, Marijn
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
