----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101295/#review3128 -----------------------------------------------------------
Ship it! Looks good in general I guess, one thing would be to match the current searching code in tables it would need to search in userinput instead of values (although I'm not quite sure which would be more expected, displayText() would probably be even better, but looking up that for every cell is a very heavy operation since it requires actual formatting of the value). And another thing still missing that the current search code has is the option to search in notes/comments. If you add those as TODO's to the code I guess it should be fine to go in since the code won't be used already anyway. - Marijn On May 5, 2011, 12:42 p.m., Arjen Hiemstra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101295/ > ----------------------------------------------------------- > > (Updated May 5, 2011, 12:42 p.m.) > > > Review request for Calligra and Marijn Kruisselbrink. > > > Summary > ------- > > This patch adds an initial implementation of KoFindBase to Tables that can > search through a Tables sheet. It does not yet do highlighting and other > features, but the basic functionality works. > > > Diffs > ----- > > tables/CMakeLists.txt dad70dc > tables/Find.h PRE-CREATION > tables/Find.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101295/diff > > > Testing > ------- > > Added the KoFindToolBar to Tables in the branch and used that to test the > code. > > > Thanks, > > Arjen > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
