-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/#review1322
-----------------------------------------------------------


- Marijn


On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100613/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2011, 12:45 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This bug fixes an issue with Calligra's zoom handling, caused by not limiting 
> the minimum and maximum zoom levels. Currently it is possible to completely 
> freeze Tables (or cause even more serious issues) by zoom out far enough.
> Zooming in on the other hand can cause you to get completely lost in your 
> document.
> 
> Note that for Krita and others, the default minimum and maximum zoom might 
> not be the best choice, which is why I included a setter for the minimum and 
> maximum values.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoZoomAction.cpp 4ef4d8b 
>   libs/widgets/KoZoomController.cpp 54b9168 
>   libs/widgets/KoZoomHandler.cpp ce234e6 
>   libs/widgets/KoZoomMode.h 9bfd195 
>   libs/widgets/KoZoomMode.cpp 293f1af 
> 
> Diff: http://git.reviewboard.kde.org/r/100613/diff
> 
> 
> Testing
> -------
> 
> Tested on Words, Stage, Tables and Krita. This patch currently breaks the 
> zoom handler unit test, which I will fix after this.
> 
> 
> Thanks,
> 
> Arjen
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to