----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120609/#review68574 -----------------------------------------------------------
Ship it! If you remove the last use of PixmapCachingSheetView you should probably also just delete that class itself? - Marijn Kruisselbrink On Oct. 16, 2014, 8:11 p.m., Philip Van Hoof wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120609/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 8:11 p.m.) > > > Review request for Calligra. > > > Bugs: 339921 > http://bugs.kde.org/show_bug.cgi?id=339921 > > > Repository: calligra > > > Description > ------- > > The PixmapCacheSheetView crashes after the getTile API retuns from the QCache > the QImage, but its use is deprecated > > > Diffs > ----- > > sheets/part/CanvasItem.cpp 9a5d77a > > Diff: https://git.reviewboard.kde.org/r/120609/diff/ > > > Testing > ------- > > More on the bug and crash explained here: > > https://bugs.kde.org/show_bug.cgi?id=339921 > > I think it's better to just stop using PixmapCacheSheetView and simply use > SheetView directly in CanvasItem. > > > Thanks, > > Philip Van Hoof > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
