Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- (Updated Sept. 19, 2011, 3:52 p.m.) Review request for Calligra. Changes

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- (Updated Sept. 19, 2011, 2:54 p.m.) Review request for Calligra. Changes

Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- Review request for Calligra. Summary --- Stores a new class KoAnchor

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6614 --- libs/kotext/KoInlineNote.h

Re: Review Request: Fix regression of group shape size

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/#review6570 --- I'd support this change. Even if shapegroup is just a logical gr

Re: Review Request: Create text box when double click in default tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/#review6550 --- hmm, so doubleclicking on a textshape, pictureshape,pathshape,v

Re: Review Request: Add support to fo:clip property in pictureshape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/#review6395 --- plugins/pictureshape/PictureShape.cpp

Re: Review Request: Add support to fo:clip property in pictureshape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/#review6394 --- I'm a bit catious about your pt to pixel conversions. let's inve

Re: Review Request: Make it possible to get a all draw styles of a defined type.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6370 --- I think in general it looks okay, and would press ship it if i f

Re: Review Request: Show on-screen keyboard when text area clicked/pressed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102515/#review6218 --- Ship it! assuming you add the ifdef you can commit - Casper

Re: Review Request: Show on-screen keyboard when text area clicked/pressed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102515/#review6217 --- thanks i assume you have seen it work so for that part it's okay

Review Request: IndexGeneratorManager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102508/ --- Review request for Calligra. Summary --- New scheduler for generating

Re: Review Request: Fix for 280461. Words crashes on double clicking in the open document window

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102392/#review6091 --- please close this now that another fix have been commited - Cas

Re: Review Request: more little things in libs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102385/#review5859 --- i'm fine with the text parts - Casper On Aug. 20, 2011, 4 p.m

Re: Review Request: Clean up the tool options widgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/#review5453 --- fine with me - Casper On Aug. 6, 2011, 6:23 p.m., Peter Simon

Re: Review Request: Styled separators in KoToolBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102233/#review5434 --- has my vote 100% - Casper On Aug. 6, 2011, 2:47 p.m., Peter S

Re: Review Request: Refactor kotext/KoTableCellStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/#review5364 --- Ship it! lots more spaces than the ones i indicated but besides

Re: Review Request: Untangle KoToolSelection and KoTextEditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102168/#review5339 --- Ship it! Since no one complained - Casper On Aug. 1, 2011, 9

Re: Review Request: Untangle KoToolSelection and KoTextEditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102168/#review5295 --- it looks fine to me, anyone with objections? - Casper On Aug.

Re: Review Request: Use the canvas' shape selection instead of the active tool to insert an inline object

ed July 29, 2011, 8:47 a.m.) > > > Review request for Calligra, Pierre Stirnweiss and Casper Boemann. > > > Summary > --- > > Using KoToolProxy->selection and casting that into a KoTextEditor is is > confusing: it is meant to allow access to the selection

Re: Review Request: immediately update the position of inline objects when inserted through KoTextEditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102109/#review5182 --- Ship it! - Casper On July 28, 2011, 12:53 p.m., Boudewijn Rem

Re: Review Request: remove unused and confusing QTextObject paramater from KoInlineObject::updatePosition.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102108/#review5180 --- Ship it! just a few small cosmetic issues, but otherwise good

Re: Review Request: Fix clipping of cosmetic pen table-borders drawn for user convenience when on screen (accuBlankBorders)

a.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --- > > The problem is that if a table-cell does not define a table-border then we > are still drawing such a table border as visual helper for the user. Those > visual helper borde

Re: Review Request: Fix text clipping

p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --- > > A while ago Hanzes tried to fix https://bugs.kde.org/show_bug.cgi?id=273177 > with commit 0568afff328a7b1d1f471d8b62f5e82f559bcc93 but back then the patch > had side-effects a

Re: Review Request: Prevent infinite layout-loop

.kde.org/r/102097/ > --- > > (Updated July 27, 2011, 2:04 p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --- > > Attached patch fixes the case that in KoTextLayoutArea.cpp we could end in an > infinite loop by trying to

Re: Review Request: Fix crash in KoColorPopupAction::updateIcon() when changing colour from outside UI thread

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102082/#review5083 --- Ship it! Well it slows things down a bit, but if you say it's n

Re: Review Request: Cleanup documentation and help calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102056/#review4997 --- ship it for words too - Casper On July 23, 2011, 8:57 a.m., B

Re: Review Request: Simplify / speed up table hit test by using qLowerBound() instead of looping

iewboard.kde.org/r/102049/ > --- > > (Updated July 22, 2011, 2:27 p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --- > > Simplify and speed up the hit test for table lay

Re: Review Request: Fix table-borders are sometimes not visible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102007/#review4858 --- Super and I approve of the approach, but Pierre is restructuring

Re: Review Request: QTextLine positioning on right-to-left

cally generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101867/ > --- > > (Updated July 6, 2011, 3:04 p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > ---

Re: Review Request: Page breaks are not saved to odt document

> On July 6, 2011, 4:38 a.m., Casper Boemann wrote: > > Hi, Thanks for the patch but the roblem is a bit bigger than that, so if > > you don't mind I'll take your patch and expand on it I've now commited the more elaborate fix, so please

Re: Review Request: Page breaks are not saved to odt document

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101854/#review4429 --- Hi, Thanks for the patch but the roblem is a bit bigger than tha

Re: Review Request: Allow paste from 'selection' on middle click.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101845/#review4378 --- Ship it! plugins/textshape/TextTool.cpp

Re: Review Request: Store text:soft-page-break as KoInlineObject.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101708/#review4056 --- Ship it! - Casper On June 21, 2011, 4:54 a.m., Thorsten Zachm

Re: Review Request: Proper handle break-after="page"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/#review3918 --- Ship it! looks ok to me - Casper On June 15, 2011, 4:16 p.m.

Re: Review Request: changes to the doc dir in calligra

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101529/#review3743 --- this sounds beneign enough to me to not evn require a review. I'

Re: Review Request: Anchored shape positioning fix

t; http://git.reviewboard.kde.org/r/101532/ > --- > > (Updated June 7, 2011, 12:49 p.m.) > > > Review request for Calligra, Casper Boemann and Sebastian Sauer. > > > Summary > --- > > This is reimplementation of the old layout anchor

Re: Review Request: Fix conflicting tool actions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/#review3661 --- Ship it! sure, let's see how it plays out, and i'll tell if it

Re: Review Request: Fix conflicting tool actions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/#review3658 --- I'm a bit sceptical as i have some shurtcut that i really want t

Re: Review Request: Fixes 274118 and couple of other fixes

ewboard.kde.org/r/101500/ > --- > > (Updated June 3, 2011, 8:11 p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --- > > This fixes bugs 274118 and 244345. This

Re: Review Request: load missing translation catalog for thesaurus plugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/#review3504 --- No idea wat it does, but I say ship it - Casper On May 25, 20

Re: Review Request: Changing from QMaps to QLists in createOptionWidgets()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101384/#review3498 --- Ship it! A few more style issues, but other than that it's time

Re: Review Request: Changing from QMaps to QLists in createOptionWidgets()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101384/#review3450 --- You are getting there :) now pull the latest change and updat

Re: Review Request: Add support for style:wrap-dynamic-threshold

atically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101361/ > --- > > (Updated May 14, 2011, 2:49 p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --

Re: Review Request: Make CellStyle in KoText support draw:opacity

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101253/#review2960 --- Wasn't this discussed only a few days ago, and the conclusion wa

Re: Review Request: Refactor of KoFind to a general interface for searching

org/r/101045/ > --- > > (Updated April 7, 2011, 12:11 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink, Boudewijn Rempt, Thorsten > Zachmann, and Casper Boemann. > > > Summary > --- > > This is the diff of the branch libs-kofind_refactor

Re: Review Request: Refactor of KoFind to a general interface for searching

--- > > (Updated April 7, 2011, 12:11 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink, Boudewijn Rempt, Thorsten > Zachmann, and Casper Boemann. > > > Summary > --- > > This is the diff of the branch libs-kofind_refact

Re: Review Request: Fix for Reducing the various hardcoded zoomlevel based on usability feedback from Anna

ted e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101022/ > --- > > (Updated April 3, 2011, 9:12 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink, Thorsten Zachmann, and > Casper Boemann.

Re: Review Request: Lists bug fixes and enhancement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100918/#review2102 --- Okay In general it looks nice. I'm however a bit worried since t

Re: Review Request: Exact ms-word font height

rd.kde.org/r/100915/ > --- > > (Updated March 22, 2011, 11:40 a.m.) > > > Review request for Calligra, Thorsten Zachmann and Casper Boemann. > > > Summary > --- > > Problem with fonts in linux and w

Re: Review Request:

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100522/#review1152 --- it looks okay to me. i noted a few TODOs that you might want to

Re: Review Request: Table of content for words

Updated Jan. 25, 2011, 1:22 p.m.) > > > Review request for Calligra, Thorsten Zachmann and Casper Boemann. > > > Summary > --- > > This patch implements the loading of the part of the ODF that says how should > be the > table of content generated (table-of-content-sour

Re: Review Request: Moving anchor strategy into text shape

p.m.) > > > Review request for Calligra and Casper Boemann. > > > Summary > --- > > This patch moves KWAnchorStrategy into text shape. > > The reason is that it is not possible to do advanced shape anchor logic > outside Layout.cpp. > > The main id