----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6614 -----------------------------------------------------------
libs/kotext/KoInlineNote.h <http://git.reviewboard.kde.org/r/102552/#comment5835> no longer needed libs/kotext/KoInlineNote.cpp <http://git.reviewboard.kde.org/r/102552/#comment5834> no longer needed libs/kotext/KoTextEditor.cpp <http://git.reviewboard.kde.org/r/102552/#comment5836> string should probably be "Insert Footnote" libs/kotext/KoTextEditor.cpp <http://git.reviewboard.kde.org/r/102552/#comment5837> string should probably be "Insert Endnote" libs/textlayout/KoTextLayoutArea.h <http://git.reviewboard.kde.org/r/102552/#comment5838> no longer needed libs/textlayout/KoTextLayoutArea.cpp <http://git.reviewboard.kde.org/r/102552/#comment5839> no longer needed libs/textlayout/KoTextLayoutArea.cpp <http://git.reviewboard.kde.org/r/102552/#comment5841> This shouldn't be commented out should it? I can however see that we need to sort out the actual code - Casper On Sept. 18, 2011, 7:02 a.m., Brijesh Patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102552/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2011, 7:02 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > I worked on implementation of Footnotes and Endnotes in Calligra Words as > part of my SoK project. > Footnotes/Endnotes can now be inserted,saved,loaded and also be configured > too. > Can somebody review my work and notify me about bugs/crashes? > > > Diffs > ----- > > libs/kotext/KoInlineNote.h 515a2f3 > libs/kotext/KoInlineNote.cpp 89200fd > libs/kotext/KoInlineTextObjectManager.h 44990e9 > libs/kotext/KoInlineTextObjectManager.cpp da8d9ca > libs/kotext/KoTextEditor.h 4947db8 > libs/kotext/KoTextEditor.cpp d6d6738 > libs/kotext/opendocument/KoTextLoader.cpp 6ce4695 > libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad > libs/odf/KoOdfNotesConfiguration.cpp bc26e31 > libs/odf/KoOdfNumberDefinition.cpp d35a07f > libs/odf/KoOdfStylesReader.cpp 35bffce > libs/textlayout/CMakeLists.txt 5a4bfff > libs/textlayout/FrameIterator.h c00a7a7 > libs/textlayout/FrameIterator.cpp 0702a2a > libs/textlayout/KoTextLayoutArea.h f356174 > libs/textlayout/KoTextLayoutArea.cpp 9aefe33 > libs/textlayout/KoTextLayoutArea_paint.cpp 6b3e293 > libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 > libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db > libs/textlayout/KoTextLayoutNoteArea.h PRE-CREATION > libs/textlayout/KoTextLayoutNoteArea.cpp PRE-CREATION > plugins/textshape/CMakeLists.txt 3df7aa5 > plugins/textshape/ReferencesTool.h c823be3 > plugins/textshape/ReferencesTool.cpp b210a35 > plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION > plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION > plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION > plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 > plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 > plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 > plugins/textshape/pics/settings-icon1_1.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102552/diff > > > Testing > ------- > > > Thanks, > > Brijesh > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
