----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102108/#review5180 -----------------------------------------------------------
Ship it! just a few small cosmetic issues, but otherwise good libs/kotext/KoTextEditor.cpp <http://git.reviewboard.kde.org/r/102108/#comment4666> spaces libs/kotext/KoTextSoftPageBreak.h <http://git.reviewboard.kde.org/r/102108/#comment4667> space at end libs/kotext/KoTextSoftPageBreak.cpp <http://git.reviewboard.kde.org/r/102108/#comment4668> space at end - Casper On July 28, 2011, 12:51 p.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102108/ > ----------------------------------------------------------- > > (Updated July 28, 2011, 12:51 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Remove unused and confusing parameter from KoInlineObject. > > The QTextObject parameter was added in the initial commit of > KoInlineObjectBase but never used. This patch removes the confusing parameter. > > > Diffs > ----- > > libs/kotext/KoBookmark.h 747dbfe > libs/kotext/KoBookmark.cpp 256111e > libs/kotext/KoInlineNote.h 0bb1106 > libs/kotext/KoInlineNote.cpp 98876c7 > libs/kotext/KoInlineObject.h 653c951 > libs/kotext/KoInlineTextObjectManager.h c6c4f15 > libs/kotext/KoTextAnchor.h f8fcd01 > libs/kotext/KoTextAnchor.cpp c0a6f8c > libs/kotext/KoTextEditor.cpp 7dba349 > libs/kotext/KoTextLocator.h d8d5f0a > libs/kotext/KoTextLocator.cpp e35ea1c > libs/kotext/KoTextMeta.h 1160079 > libs/kotext/KoTextMeta.cpp 4f0fd18 > libs/kotext/KoTextSoftPageBreak.h af311a9 > libs/kotext/KoTextSoftPageBreak.cpp b961541 > libs/kotext/KoVariable.h eb0e465 > libs/kotext/KoVariable.cpp fe53f2e > libs/kotext/changetracker/KoDeleteChangeMarker.h 4e90dcb > libs/kotext/changetracker/KoDeleteChangeMarker.cpp 1ce3c32 > libs/kotext/opendocument/KoTextLoader.cpp eadeeae > > Diff: http://git.reviewboard.kde.org/r/102108/diff > > > Testing > ------- > > ran the tests & words. > > > Thanks, > > Boudewijn > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
