----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102082/#review5083 -----------------------------------------------------------
Ship it! Well it slows things down a bit, but if you say it's needed.. - Casper On July 25, 2011, 11:30 a.m., Dan Leinir Turthra Jensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102082/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 11:30 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > If one were to call addController without ensuring this happened in the UI > thread, or before painter was ready, the previous code would cause a > segfault. This diff fixes the problem. > > > Diffs > ----- > > libs/widgets/KoColorPopupAction.cpp d97a04c > > Diff: http://git.reviewboard.kde.org/r/102082/diff > > > Testing > ------- > > Constructing tools outside the main thread, no crashes could be provoked in > the new code. > > > Thanks, > > Dan Leinir Turthra > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
