----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6370 -----------------------------------------------------------
I think in general it looks okay, and would press ship it if i felt I had the authority One important comment though: libs/odf/KoOdfStylesReader.h <http://git.reviewboard.kde.org/r/102562/#comment5674> some apidoc of the argument would be very appreciated - Casper On Sept. 10, 2011, 6:28 a.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102562/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2011, 6:28 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > This patch makes it possible to get all gradients, markers, ... from the > styles reader. It is needed when we don't want to load the same stuff over > and over again. > I will use it in my marker branch to get all markers and load them in one go > and just reuse them later. > > There is no change in functionality for the extiting applications. > > > Diffs > ----- > > libs/flake/KoPatternBackground.cpp 4210ab48 > libs/odf/KoOdfGraphicStyles.cpp 9e9653f > libs/odf/KoOdfStylesReader.h acab80f > libs/odf/KoOdfStylesReader.cpp 5a8324e > plugins/chartshape/Surface.cpp e22a6b2 > > Diff: http://git.reviewboard.kde.org/r/102562/diff > > > Testing > ------- > > Run cstester and no problems found in the documents of my test set (~1500 > docs) > > > Thanks, > > Thorsten > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
